Skip to content

fix(core): remove unused finding categories - #129

Merged
Muawiya-contact merged 3 commits into
mainfrom
codex/fix-unused-finding-categories
Sep 12, 2026
Merged

fix(core): remove unused finding categories#129
Muawiya-contact merged 3 commits into
mainfrom
codex/fix-unused-finding-categories

Conversation

@Muawiya-contact

Copy link
Copy Markdown
Member

Closes #70.

What changed

  • Removed the dead DuplicateFile and EmptyDirectory category variants from diskern-core.
  • Removed the matching CLI and desktop labels so the frontends only describe categories the engine can actually produce.
  • Updated the stale exclude test expectation after the singular scan summary fix landed on main.
  • Added a changelog note.

The duplicate report stays available through report.duplicate_sets, so users still see duplicate files in the dedicated duplicate section:

pub struct Report {
    pub duplicate_sets: Vec<dedup::DuplicateSet>,
}

Validation

cargo fmt --check
cargo test -p diskern-core -p diskern-cli --all-features
cargo clippy -p diskern-core -p diskern-cli --all-targets --all-features -- -D warnings
cd app && npm run build

@Muawiya-contact Muawiya-contact left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Muawiya-contact
Muawiya-contact merged commit 57c2212 into main Sep 12, 2026
12 checks passed
@Muawiya-contact
Muawiya-contact deleted the codex/fix-unused-finding-categories branch September 12, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The DuplicateFile and EmptyDirectory categories are never produced

1 participant