Skip to content

fix(actions): shorten quarantine names for Windows paths - #125

Merged
Muawiya-contact merged 1 commit into
mainfrom
codex/fix-quarantine-path-length
Sep 12, 2026
Merged

fix(actions): shorten quarantine names for Windows paths#125
Muawiya-contact merged 1 commit into
mainfrom
codex/fix-quarantine-path-length

Conversation

@Muawiya-contact

Copy link
Copy Markdown
Member

What changed

This fixes quarantine destination names that could push the full quarantine path past the legacy Windows 260-character limit.

The quarantine filename is now shortened based on the quarantine directory length, not only a fixed flattened-name size. It still keeps the useful tail of the original path, and the manifest remains the source of truth for restore.

Closes #67.

Notes

  • Keeps the filename under the 255-byte filename budget.
  • Leaves room for collision suffixes such as .1 and the worst-case u32 suffix.
  • Applies the full-path budget only on Windows; other platforms keep the filename-budget behavior.

Validation

  • cargo fmt --check
  • cargo test -p diskern-core -p diskern-cli --all-features
  • cargo clippy -p diskern-core -p diskern-cli --all-targets --all-features -- -D warnings

@Muawiya-contact Muawiya-contact left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Muawiya-contact
Muawiya-contact merged commit 9cc4fc8 into main Sep 12, 2026
12 checks passed
@Muawiya-contact
Muawiya-contact deleted the codex/fix-quarantine-path-length branch September 12, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quarantine can build a path longer than Windows allows

1 participant