Skip to content

Run the site theme tests in CI #113

Description

@Muawiya-contact

#108 added three tests in site/tests/theme-root.test.js and an npm test script. They pass locally, but CI never runs them.

The site job in .github/workflows/ci.yml currently runs:

- run: npm ci
- run: npm run lint
- run: npm run build

Add - run: npm test after lint and before the build. This keeps a future theme regression from merging with a green build.

Done when: all three tests run on a pull request, and a failing assertion fails the site job.

cd site
npm ci
npm test

Confirmed on 8abd5cb: three local tests pass; the workflow has no site test step. This is separate from #109, which covers Rust desktop tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingciCI workflows and release automationfrontendThe desktop app's UI layergood first issueGood for newcomershelp wantedExtra attention is neededlevel: beginnerSmall and well-scoped; no deep context neededpriority: mediumWorth doing, not urgenttestingTest coverage and test tooling

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions