Skip to content

fix(ng): adapt to @clevercloud/client v12 API change for peer config#1074

Merged
hsablonniere merged 1 commit intomasterfrom
ng/fix-config
Apr 2, 2026
Merged

fix(ng): adapt to @clevercloud/client v12 API change for peer config#1074
hsablonniere merged 1 commit intomasterfrom
ng/fix-config

Conversation

@pdesoyres-cc
Copy link
Copy Markdown
Contributor

@pdesoyres-cc pdesoyres-cc commented Mar 18, 2026

Summary

  • Upgrade @clevercloud/client from v11.3.0 to v12.0.0
  • Adapt NG peer config handling to the new API response format (plain text instead of base64-encoded JSON)
  • Remove the --format option (no JSON format anymore)

Test plan

  • Run clever ng get-config and verify the WireGuard configuration is displayed as plain text

@pdesoyres-cc pdesoyres-cc requested a review from a team as a code owner March 18, 2026 07:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

🔎 The preview has been automatically deleted.

@davlgd
Copy link
Copy Markdown
Contributor

davlgd commented Mar 18, 2026

Build a structured return object {ngId, peerId, configuration} in getPeerConfig instead of forwarding the raw API response

I don't think we need this, as this command is here to provide the configuration of a peer in the WireGuard config file format. We provided json format before to get the raw API response. If a user need information about a network group/peer in json format, get command will handle it.

@pdesoyres-cc pdesoyres-cc force-pushed the ng/fix-config branch 2 times, most recently from 34628c1 to 7ae1c27 Compare March 19, 2026 09:18
The NG peer config endpoint now returns plain text instead of a
base64-encoded JSON object, requiring adjustments to how the
configuration is read and displayed.
@pdesoyres-cc
Copy link
Copy Markdown
Contributor Author

@davlgd. Considering your review, I removed the support of json format for this command.

Copy link
Copy Markdown
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with up to date client and it works.

LGTM 👍

@hsablonniere hsablonniere merged commit d1c6df1 into master Apr 2, 2026
6 checks passed
@hsablonniere hsablonniere deleted the ng/fix-config branch April 2, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants