Skip to content

feat(drain): add test-command subcommand#1073

Open
KannarFr wants to merge 1 commit intomasterfrom
feat/drain-test-command
Open

feat(drain): add test-command subcommand#1073
KannarFr wants to merge 1 commit intomasterfrom
feat/drain-test-command

Conversation

@KannarFr
Copy link
Copy Markdown
Member

@KannarFr KannarFr commented Mar 16, 2026

Summary

  • Add getDrainTestCommand API client method for the GET .../drains/{drainId}/test-command endpoint
  • Add clever drain test-command <drain-id> subcommand that returns a ready-to-execute shell command (curl/netcat) to manually test a drain recipient

Test plan

  • clever drain test-command <drain-id> --app <app> returns a valid shell command for HTTP drains (curl)
  • clever drain test-command <drain-id> --app <app> returns a valid shell command for syslog drains (netcat)
  • clever drain test-command --help displays correct usage
  • Other drain commands (create, get, disable, enable, remove) still work with --app

🤖 Generated with Claude Code

@KannarFr KannarFr requested a review from a team as a code owner March 16, 2026 15:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

🔎 A preview has been automatically published!

If you created the alias to the preview script, you can run this command to download and install this preview:

clever-preview update feat-drain-test-command

You can also run it from your local repository:

./scripts/preview.js update feat-drain-test-command
OS SHA256 checksum
🐧 linux c82b3a6d197e8e4918d1bbc8998b8ffc26642072dc9d9ecf9c5de280119314d2
🍏 macos 9ee87eebf1b655f676f1c759ce2df3f4bf5e7b2eb25cc5015df9e5d15537f2bb

This preview will be deleted once this PR is closed.

@KannarFr KannarFr force-pushed the feat/drain-test-command branch 4 times, most recently from b2678a6 to 9cbcf08 Compare March 16, 2026 16:39
Add `clever drain test-command <drain-id>` which returns a shell command
(curl or netcat) to manually test a drain recipient.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@KannarFr KannarFr force-pushed the feat/drain-test-command branch from 9cbcf08 to 9707cea Compare March 16, 2026 16:45
@davlgd
Copy link
Copy Markdown
Contributor

davlgd commented Mar 18, 2026

Revert --resource option on drain commands, use --app only for now

Is there a specific reason for this?

@KannarFr
Copy link
Copy Markdown
Member Author

Revert --resource option on drain commands, use --app only for now

Is there a specific reason for this?

No, it was bad branch management, removing it from overview.

@hsablonniere
Copy link
Copy Markdown
Member

@KannarFr Can you give more context?

From what I understood, we output a shell command that users can run to call their own app to mimick what we do when we send logs to drains.

  1. Why don't we do the call on the backend side ourselves?
  2. Won't we have differences between what we really do (headers, IPs...)?

I expected a similar UX as when I setup a hook on GitHub for example.

image

Naming nitpick: I expected test-command to test something (and do a call on the backend side), no to output (get) et command.

@KannarFr
Copy link
Copy Markdown
Member Author

KannarFr commented Apr 1, 2026

Yes I agree on your statements, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants