fix(cc-token-api-*): pass API bridge URL as a prop instead of hardcoding it#1715
Open
fix(cc-token-api-*): pass API bridge URL as a prop instead of hardcoding it#1715
Conversation
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-token-api-update-form/add-api-bridge-prop/index.html. This preview will be deleted once this PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1714
What does this PR do?
apiBridgeHrefprop tocc-token-api-update-form,cc-token-api-list, andcc-token-api-creation-form,https://api-bridge.clever-cloud.comin the curl example with the prop value,new URL()to safely join the path (handles trailing slashes),apiConfig.AUTH_BRIDGE_HOSTto the new prop,https://api-bridge.clever-cloud.comwhen the prop is not set.How to review?
withCustomApiBridgeHrefstory in Storybook for each component,