refactor(eslint): add sort-lit-element-members rule#1712
Open
refactor(eslint): add sort-lit-element-members rule#1712
Conversation
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/eslint/members-sort-plugin/index.html. This preview will be deleted once this PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
LitElement components in this codebase follow a conventional member ordering defined in
docs/cc-example-component.js:properties → static members → constructor → public methods → private methods → event handlers → lifecycle → render → sub-render → styles.
This ordering was not enforced, and several components had members out of order.
What does this PR do?
lit-cc/sort-element-members) that enforces the conventional member ordering with autofix,extends LitElementor the presence ofstatic get properties()/static get styles(),@types/estreeas a dev dependency for proper typing,How to review?
npm run test:mocha -- --grep "sort-lit-element-members"— 13 tests pass,