Conversation
1 task
lianctrl
approved these changes
Apr 29, 2025
Contributor
lianctrl
left a comment
lianctrl
left a comment
There was a problem hiding this comment.
For the records, I used the polynomial fit here implemented to fit quartic angles prior onto the NTL9 dataset and the fit looks good, with consistently keeping the features we discussed:
- higher energy barriers at the boundaries
- keeping convexity at the boundaries
Collaborator
Author
|
LGTM, wil squash and merge |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using MLCG tk with a
QuarticAnglesprior that uses a degree-4 polynomial to fit angles.This PR is coupled to another PR in mlcg implementing such prior.
The
examples/configuration_files/carbon_alpha_configs/ca_trpcage_priors.yamlhas been modified to use the new quartic prior. It can be tested with this.