[Fusion] Perf experiment 2

src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/HttpPostMiddlewareBase.cs

@@ -259,7 +259,13 @@ await session.RequestParser.ParseRequestAsync(
 
         foreach (var request in requests)
         {
-            context.Response.RegisterForDispose(request);
+            if (request.Variables is not null
+                || request.Extensions is not null
+                || request.VariablesMemoryOwner is not null
+                || request.ExtensionsMemoryOwner is not null)
+            {
+                context.Response.RegisterForDispose(request);
+            }
         }
 
         return requests;

src/HotChocolate/AspNetCore/src/Transport.Http/GraphQLHttpResponse.cs

@@ -176,6 +176,15 @@ private async ValueTask<OperationResult> ReadAsResultInternalAsync(string? charS
         var chunkIndex = 0;
         var chunks = ArrayPool<byte[]>.Shared.Rent(64);
 
+        static byte[][] GrowChunkArray(byte[][] chunkArray)
+        {
+            var newChunks = ArrayPool<byte[]>.Shared.Rent(chunkArray.Length * 2);
+            Array.Copy(chunkArray, 0, newChunks, 0, chunkArray.Length);
+            chunkArray.AsSpan().Clear();
+            ArrayPool<byte[]>.Shared.Return(chunkArray);
+            return newChunks;
+        }
+
         try
         {
             while (true)
@@ -219,10 +228,7 @@ private async ValueTask<OperationResult> ReadAsResultInternalAsync(string? charS
                             {
                                 if (chunkIndex >= chunks.Length)
                                 {
-                                    var newChunks = ArrayPool<byte[]>.Shared.Rent(chunks.Length * 2);
-                                    Array.Copy(chunks, 0, newChunks, 0, chunks.Length);
-                                    chunks.AsSpan().Clear();
-                                    chunks = newChunks;
+                                    chunks = GrowChunkArray(chunks);
                                 }
 
                                 chunks[chunkIndex++] = currentChunk;
@@ -257,10 +263,7 @@ private async ValueTask<OperationResult> ReadAsResultInternalAsync(string? charS
                             {
                                 if (chunkIndex >= chunks.Length)
                                 {
-                                    var newChunks = ArrayPool<byte[]>.Shared.Rent(chunks.Length * 2);
-                                    Array.Copy(chunks, 0, newChunks, 0, chunks.Length);
-                                    chunks.AsSpan().Clear();
-                                    chunks = newChunks;
+                                    chunks = GrowChunkArray(chunks);
                                 }
 
                                 chunks[chunkIndex++] = currentChunk;
@@ -277,10 +280,7 @@ private async ValueTask<OperationResult> ReadAsResultInternalAsync(string? charS
             // add the final partial chunk to the list
             if (chunkIndex >= chunks.Length)
             {
-                var newChunks = ArrayPool<byte[]>.Shared.Rent(chunks.Length * 2);
-                Array.Copy(chunks, 0, newChunks, 0, chunks.Length);
-                chunks.AsSpan().Clear();
-                chunks = newChunks;
+                chunks = GrowChunkArray(chunks);
             }
 
             chunks[chunkIndex++] = currentChunk;

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Clients/SourceSchemaHttpClient.cs

@@ -191,7 +191,7 @@ private GraphQLHttpRequest CreateHttpRequest(
     private GraphQLHttpRequest CreateHttpBatchRequest(
         IReadOnlyList<SourceSchemaClientRequest> originalRequests)
     {
-        var batchRequests = new List<IOperationRequest>(originalRequests.Count);
+        var batchRequests = new IOperationRequest[originalRequests.Count];
         var enableFileUploads = false;
 
         for (var i = 0; i < originalRequests.Count; i++)
@@ -200,15 +200,13 @@ private GraphQLHttpRequest CreateHttpBatchRequest(
             enableFileUploads |= sourceRequest.RequiresFileUpload;
 
             var body = CreateRequestBody(sourceRequest);
-            if (body is IOperationRequest operationRequest)
-            {
-                batchRequests.Add(operationRequest);
-            }
-            else
+            if (body is not IOperationRequest operationRequest)
             {
                 throw new InvalidOperationException(
                     $"The request body type '{body.GetType().Name}' cannot be included in an operation batch.");
             }
+
+            batchRequests[i] = operationRequest;
         }
 
         return new GraphQLHttpRequest(new OperationBatchRequest(batchRequests))

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Clients/SourceSchemaHttpClientConfiguration.cs

@@ -218,29 +218,29 @@ private static class AcceptContentTypes
     {
         public static ImmutableArray<MediaTypeWithQualityHeaderValue> Default { get; } =
         [
-            new("application/graphql-response+json") { CharSet = "utf-8" },
-            new("application/json") { CharSet = "utf-8" },
-            new("application/jsonl") { CharSet = "utf-8" },
-            new("text/event-stream") { CharSet = "utf-8" }
+            new("application/graphql-response+json"),
+            new("application/json"),
+            new("application/jsonl"),
+            new("text/event-stream")
         ];
 
         public static ImmutableArray<MediaTypeWithQualityHeaderValue> VariableBatching { get; } =
         [
-            new("application/jsonl") { CharSet = "utf-8" },
-            new("text/event-stream") { CharSet = "utf-8" },
-            new("application/graphql-response+json") { CharSet = "utf-8" },
-            new("application/json") { CharSet = "utf-8" }
+            new("application/jsonl"),
+            new("text/event-stream"),
+            new("application/graphql-response+json"),
+            new("application/json")
         ];
 
         public static ImmutableArray<MediaTypeWithQualityHeaderValue> ApolloRequestBatching { get; } =
         [
-            new("application/json") { CharSet = "utf-8" }
+            new("application/json")
         ];
 
         public static ImmutableArray<MediaTypeWithQualityHeaderValue> Subscription { get; } =
         [
-            new("application/jsonl") { CharSet = "utf-8" },
-            new("text/event-stream") { CharSet = "utf-8" }
+            new("application/jsonl"),
+            new("text/event-stream")
         ];
     }
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/ExecutionNode.cs

@@ -50,9 +50,10 @@ public async Task ExecuteAsync(
         OperationPlanContext context,
         CancellationToken cancellationToken = default)
     {
-        var start = Stopwatch.GetTimestamp();
+        var collectTelemetry = context.CollectTelemetry;
+        var start = collectTelemetry ? Stopwatch.GetTimestamp() : 0L;
         var scope = CreateScope(context);
-        var activity = Activity.Current;
+        var activity = collectTelemetry ? Activity.Current : null;
         ExecutionStatus status;
         Exception? error = null;
 
@@ -78,15 +79,20 @@ public async Task ExecuteAsync(
             scope?.Dispose();
         }
 
+        var duration = collectTelemetry ? Stopwatch.GetElapsedTime(start) : default;
+        var dependentsToExecute = context.GetDependentsToExecute(this);
+        var variableValueSets = collectTelemetry ? context.GetVariableValueSets(this) : [];
+        var transportDetails = collectTelemetry ? context.GetTransportDetails(this) : default;
+
         var result = new ExecutionNodeResult(
             Id,
             activity,
             status,
-            Stopwatch.GetElapsedTime(start),
+            duration,
             error,
-            context.GetDependentsToExecute(this),
-            context.GetVariableValueSets(this),
-            context.GetTransportDetails(this));
+            dependentsToExecute,
+            variableValueSets,
+            transportDetails);
 
         context.CompleteNode(result);
     }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/OperationBatchExecutionNode.cs

@@ -1,6 +1,5 @@
 using System.Buffers;
 using System.Collections.Immutable;
-using System.Runtime.InteropServices;
 using HotChocolate.Fusion.Execution.Clients;
 
 namespace HotChocolate.Fusion.Execution.Nodes;
@@ -112,7 +111,12 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
 
         var schemaName = _schemaName ?? context.GetDynamicSchemaName(this);
 
-        context.TrackVariableValueSets(this, variables);
+        var collectTelemetry = context.CollectTelemetry;
+
+        if (collectTelemetry)
+        {
+            context.TrackVariableValueSets(this, variables);
+        }
 
         var request = new SourceSchemaClientRequest
         {
@@ -137,7 +141,10 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
             var response = await context.SourceSchemaScheduler
                 .ExecuteAsync(request, cancellationToken)
                 .ConfigureAwait(false);
-            context.TrackSourceSchemaClientResponse(this, response);
+            if (collectTelemetry)
+            {
+                context.TrackSourceSchemaClientResponse(this, response);
+            }
 
             // we read the responses from the response stream.
             var totalPathCount = variables.Length;
@@ -225,10 +232,9 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
             }
             else if (singleResult is not null)
             {
-                var firstResult = singleResult;
-                context.AddPartialResults(
+                context.AddPartialResult(
                     _source,
-                    MemoryMarshal.CreateReadOnlySpan(ref firstResult, 1),
+                    singleResult,
                     _responseNames,
                     hasSomeErrors);
             }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/OperationExecutionNode.cs

@@ -118,7 +118,12 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
 
         var schemaName = _schemaName ?? context.GetDynamicSchemaName(this);
 
-        context.TrackVariableValueSets(this, variables);
+        var collectTelemetry = context.CollectTelemetry;
+
+        if (collectTelemetry)
+        {
+            context.TrackVariableValueSets(this, variables);
+        }
 
         var request = new SourceSchemaClientRequest
         {
@@ -143,18 +148,11 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
             var response = await context.SourceSchemaScheduler
                 .ExecuteAsync(request, cancellationToken)
                 .ConfigureAwait(false);
-            context.TrackSourceSchemaClientResponse(this, response);
-
-            // we read the responses from the response stream.
-            var totalPathCount = variables.Length;
-
-            for (var i = 0; i < variables.Length; i++)
+            if (collectTelemetry)
             {
-                totalPathCount += variables[i].AdditionalPaths.Length;
+                context.TrackSourceSchemaClientResponse(this, response);
             }
 
-            var initialBufferLength = Math.Max(totalPathCount, 2);
-
             await foreach (var result in response.ReadAsResultStreamAsync(cancellationToken))
             {
                 // If there is only one response, we skip the buffer rental.
@@ -168,7 +166,14 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
                     // If we have more than one response, we rent a buffer and move the first result into it.
                     if (buffer is null)
                     {
-                        bufferLength = initialBufferLength;
+                        var totalPathCount = variables.Length;
+
+                        for (var i = 0; i < variables.Length; i++)
+                        {
+                            totalPathCount += variables[i].AdditionalPaths.Length;
+                        }
+
+                        bufferLength = Math.Max(totalPathCount, 2);
                         buffer = ArrayPool<SourceSchemaResult>.Shared.Rent(bufferLength);
                         buffer[0] = singleResult!;
                     }
@@ -229,10 +234,9 @@ protected override async ValueTask<ExecutionStatus> OnExecuteAsync(
             }
             else if (singleResult is not null)
             {
-                var firstResult = singleResult;
-                context.AddPartialResults(
+                context.AddPartialResult(
                     _source,
-                    MemoryMarshal.CreateReadOnlySpan(ref firstResult, 1),
+                    singleResult,
                     _responseNames,
                     hasSomeErrors);
             }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/Selection.cs

@@ -13,6 +13,7 @@ public sealed class Selection : ISelection
     private readonly FieldSelectionNode[] _syntaxNodes;
     private readonly ulong[] _includeFlags;
     private readonly byte[] _utf8ResponseName;
+    private SelectionSetCacheEntry? _selectionSetCache;
     private Flags _flags;
 
     public Selection(
@@ -44,6 +45,17 @@ public Selection(
             _flags |= Flags.Leaf;
         }
 
+        IType fieldType = field.Type;
+        while (fieldType.Kind is TypeKind.NonNull)
+        {
+            fieldType = fieldType.InnerType();
+        }
+
+        if (fieldType.Kind is TypeKind.Scalar or TypeKind.Enum)
+        {
+            _flags |= Flags.LeafValue;
+        }
+
         _utf8ResponseName = Utf8StringCache.GetUtf8String(responseName);
     }
 
@@ -64,6 +76,8 @@ public Selection(
     /// <inheritdoc />
     public bool IsLeaf => (_flags & Flags.Leaf) == Flags.Leaf;
 
+    internal bool IsLeafValue => (_flags & Flags.LeafValue) == Flags.LeafValue;
+
     /// <inheritdoc />
     public IOutputFieldDefinition Field { get; }
 
@@ -85,6 +99,22 @@ public Selection(
 
     internal ResolveFieldValue? Resolver => Field.Features.Get<ResolveFieldValue>();
 
+    internal SelectionSet GetSelectionSet(IObjectTypeDefinition typeContext)
+    {
+        ArgumentNullException.ThrowIfNull(typeContext);
+
+        var cache = _selectionSetCache;
+
+        if (cache is not null && ReferenceEquals(cache.TypeContext, typeContext))
+        {
+            return cache.SelectionSet;
+        }
+
+        var selectionSet = DeclaringSelectionSet.DeclaringOperation.GetSelectionSet(this, typeContext);
+        _selectionSetCache = new SelectionSetCacheEntry(typeContext, selectionSet);
+        return selectionSet;
+    }
+
     IEnumerable<FieldNode> ISelection.GetSyntaxNodes()
     {
         for (var i = 0; i < SyntaxNodes.Length; i++)
@@ -169,6 +199,16 @@ private enum Flags
         None = 0,
         Internal = 1,
         Leaf = 2,
-        Sealed = 4
+        Sealed = 4,
+        LeafValue = 8
+    }
+
+    private sealed class SelectionSetCacheEntry(
+        IObjectTypeDefinition typeContext,
+        SelectionSet selectionSet)
+    {
+        public IObjectTypeDefinition TypeContext { get; } = typeContext;
+
+        public SelectionSet SelectionSet { get; } = selectionSet;
     }
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/SelectionPath.cs

@@ -1,5 +1,6 @@
 using System.Collections.Immutable;
 using System.Text;
+using HotChocolate.Fusion.Text;
 
 namespace HotChocolate.Fusion.Execution.Nodes;
 
@@ -355,7 +356,13 @@ public override string ToString()
     /// </summary>
     /// <param name="Name">The name of the field or type for this segment.</param>
     /// <param name="Kind">The kind of segment (field or inline fragment).</param>
-    public sealed record Segment(string Name, SelectionPathSegmentKind Kind);
+    public sealed record Segment(string Name, SelectionPathSegmentKind Kind)
+    {
+        private byte[]? _utf8Name;
+
+        public ReadOnlySpan<byte> Utf8Name
+            => _utf8Name ??= Utf8StringCache.GetUtf8String(Name);
+    }
 
     /// <summary>
     /// Creates a new builder for creating <see cref="SelectionPath"/> instances.