Adding limit and offset as params to read.socrata#127
Open
userfog wants to merge 2 commits intoChicago:masterfrom
Open
Adding limit and offset as params to read.socrata#127userfog wants to merge 2 commits intoChicago:masterfrom
userfog wants to merge 2 commits intoChicago:masterfrom
Conversation
|
Hi @userfog, thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All!
My name is Zach and I live, work, enjoy municipal data, and code in R in Chicago. Needless to say when I saw this package and saw that it was being developed here I was very excited.
I added limit and offset as params to the read.socrata function because on your road map it said you were interested in adding fine grained args to the call.
I won't be offended if you do not accept the request, the PR also gave me an excuse to introduce myself.
Best,
Zach
p.s. Sorry for not adding any tests, I did run the existing ones.
OK: 140 SKIPPED: 0 FAILED: 0