Skip to content

fix(query): resolve false positive on ALB WAF integration with WAFv2 #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-prathmesh-borle wants to merge 1 commit into
base: master
Choose a base branch
from
+86 −2
Open

fix(query): resolve false positive on ALB WAF integration with WAFv2 #8004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions assets/queries/cloudFormation/aws/alb_is_not_integrated_with_waf/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,28 @@ internal_alb(resource) {
scheme == "internal"
}

waf_association_types := {"AWS::WAFRegional::WebACLAssociation", "AWS::WAFv2::WebACLAssociation"}

associated_waf(target_alb) {
resource := input.document[_].Resources[_]
resource.Type == "AWS::WAFRegional::WebACLAssociation"
waf_association_types[resource.Type]
resource.Properties.ResourceArn.Ref == target_alb
}

associated_waf(target_alb) {
resource := input.document[_].Resources[_]
resource.Type == "AWS::WAFRegional::WebACLAssociation"
waf_association_types[resource.Type]
resource.Properties.ResourceArn == target_alb
}

associated_waf(target_alb) {
resource := input.document[_].Resources[_]
waf_association_types[resource.Type]
resource.Properties.ResourceArn["Fn::GetAtt"][0] == target_alb
}

associated_waf(target_alb) {
resource := input.document[_].Resources[_]
waf_association_types[resource.Type]
startswith(resource.Properties.ResourceArn, sprintf("%s.", [target_alb]))
}
12 changes: 12 additions & 0 deletions assets/queries/cloudFormation/aws/alb_is_not_integrated_with_waf/test/negative3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
AWSTemplateFormatVersion: 2010-09-09
Resources:
MyLoadBalancerV2:
Type: AWS::ElasticLoadBalancingV2::LoadBalancer
Properties:
Name: myloadbalancerv2
Scheme: internet-facing
MyWebACLAssociation:
Type: "AWS::WAFv2::WebACLAssociation"
Properties:
ResourceArn: !GetAtt MyLoadBalancerV2.LoadBalancerArn
WebACLArn: !Ref MyWebACL
23 changes: 23 additions & 0 deletions assets/queries/cloudFormation/aws/alb_is_not_integrated_with_waf/test/negative4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"AWSTemplateFormatVersion": "2010-09-09T00:00:00Z",
"Resources": {
"MyLoadBalancerV2": {
"Type": "AWS::ElasticLoadBalancingV2::LoadBalancer",
"Properties": {
"Name": "myloadbalancerv2",
"Scheme": "internet-facing"
}
},
"MyWebACLAssociation": {
"Type": "AWS::WAFv2::WebACLAssociation",
"Properties": {
"ResourceArn": {
"Ref": "MyLoadBalancerV2"
},
"WebACLArn": {
"Ref": "MyWebACL"
}
}
}
}
}
12 changes: 12 additions & 0 deletions assets/queries/cloudFormation/aws/alb_is_not_integrated_with_waf/test/negative5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
AWSTemplateFormatVersion: 2010-09-09
Resources:
MyLoadBalancerV2b:
Type: AWS::ElasticLoadBalancingV2::LoadBalancer
Properties:
Name: myloadbalancerv2b
Scheme: internet-facing
MyWebACLAssociation:
Type: "AWS::WAFv2::WebACLAssociation"
Properties:
ResourceArn: !Ref MyLoadBalancerV2b
WebACLArn: !Ref MyWebACL
23 changes: 23 additions & 0 deletions assets/queries/cloudFormation/aws/alb_is_not_integrated_with_waf/test/negative6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"AWSTemplateFormatVersion": "2010-09-09T00:00:00Z",
"Resources": {
"MyLoadBalancerV2c": {
"Type": "AWS::ElasticLoadBalancingV2::LoadBalancer",
"Properties": {
"Name": "myloadbalancerv2c",
"Scheme": "internet-facing"
}
},
"MyWebACLAssociation": {
"Type": "AWS::WAFv2::WebACLAssociation",
"Properties": {
"ResourceArn": {
"Fn::GetAtt": ["MyLoadBalancerV2c", "LoadBalancerArn"]
},
"WebACLArn": {
"Ref": "MyWebACL"
}
}
}
}
}
Loading