-
Notifications
You must be signed in to change notification settings - Fork 361
feat(tests): improving E2E HTML report and output on remediation tests #7955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cx-ricardo-jesus
wants to merge
93
commits into
master
Choose a base branch
from
AST-131335
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
0c27999
first commit
cx-ricardo-jesus eb03647
rewrite previous changes
cx-ricardo-jesus 6c9cf4a
Merge branch 'master' into AST-131335
cx-ricardo-jesus 19e0bd4
causing remediation error on purpose
cx-ricardo-jesus 2e8cdbb
some changes
cx-ricardo-jesus a42bc85
Merge branch 'master' into AST-131335
cx-ricardo-jesus c749f8a
Merge branch 'AST-131335' of https://github.com/Checkmarx/kics into A…
cx-ricardo-jesus 9a1d89e
.
cx-ricardo-jesus 999f519
.
cx-ricardo-jesus 28e72b7
added remediatedFiles to error output in remediation tests
cx-ricardo-jesus f25c25d
restored directories removed by mistake
cx-ricardo-jesus 3b6fc7b
removed files
cx-ricardo-jesus d46e5d2
Delete assets/queries/terraform/aws/api_gateway_access_logging_disabl…
cx-ricardo-jesus 2324498
Delete assets/queries/terraform/aws/sns_topic_is_publicly_accessible/…
cx-ricardo-jesus 0c1591f
Delete assets/queries/terraform/aws/sns_topic_is_publicly_accessible/…
cx-ricardo-jesus c510194
Delete assets/queries/terraform/aws/sns_topic_is_publicly_accessible/…
cx-ricardo-jesus 4968d3c
Delete assets/queries/terraform/gcp/ensure_essential_contacts_is_conf…
cx-ricardo-jesus 3aa6cbd
Delete assets/queries/terraform/gcp/ensure_essential_contacts_is_conf…
cx-ricardo-jesus cb497eb
Delete assets/queries/terraform/gcp/ensure_gke_version_management_is_…
cx-ricardo-jesus ca020a8
Delete assets/queries/terraform/gcp/ensure_gke_version_management_is_…
cx-ricardo-jesus 78a9bc4
Delete assets/queries/terraform/gcp/google_kubernetes_engine_cluster_…
cx-ricardo-jesus 1cb64f3
Delete assets/queries/terraform/gcp/legacy_networks_do_not_exist_for_…
cx-ricardo-jesus 35f58ed
Delete assets/queries/terraform/gcp/legacy_networks_do_not_exist_for_…
cx-ricardo-jesus 592a71d
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_audit_con…
cx-ricardo-jesus 4a74aa1
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_audit_con…
cx-ricardo-jesus f29fc53
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_custom_ro…
cx-ricardo-jesus c40edee
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_custom_ro…
cx-ricardo-jesus 9ff072d
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_project_o…
cx-ricardo-jesus 2f4c596
Delete assets/queries/terraform/gcp/logs_and_alerts_missing_project_o…
cx-ricardo-jesus ad398f9
Delete assets/queries/terraform/gcp/shielded_gke_node_do_not_have_int…
cx-ricardo-jesus 7893396
Delete assets/queries/terraform/gcp/shielded_gke_node_do_not_have_int…
cx-ricardo-jesus e4b68a8
Delete assets/queries/terraform/gcp/sql_db_instance_external_scripts_…
cx-ricardo-jesus 7f63618
Delete assets/queries/terraform/gcp/sql_db_instance_external_scripts_…
cx-ricardo-jesus c7214e2
Delete assets/queries/terraform/gcp/sql_db_instance_external_scripts_…
cx-ricardo-jesus 6888aba
added remediation problems to the query
cx-ricardo-jesus 3fad6f1
Merge branch 'AST-131335' of https://github.com/Checkmarx/kics into A…
cx-ricardo-jesus 80d28cb
fixed golint problems
cx-ricardo-jesus 2e17dd9
golint
cx-ricardo-jesus 57a64f4
change on the query
cx-ricardo-jesus 5884529
fixing line that surpasses the 140 characters limits by go-ci/lint
cx-ricardo-jesus aa1c84b
.
cx-ricardo-jesus d54492e
changed e2e test to see HTML results output
cx-ricardo-jesus edb5748
Merge branch 'master' into AST-131335
cx-ricardo-jesus d081d71
.
cx-ricardo-jesus d8fe0fb
.
cx-ricardo-jesus f70dac6
.
cx-ricardo-jesus 14bc55a
removed one query in the results
cx-ricardo-jesus d2bdcf4
Merge branch 'master' into AST-131335
cx-ricardo-jesus e9ac7bd
indenting json output on E2E test HTML report
cx-ricardo-jesus 31f1048
changed fixture results
cx-ricardo-jesus 2cf7ffa
Merge branch 'master' of https://github.com/Checkmarx/kics into AST-1…
cx-ricardo-jesus 51211b8
changed comparison using listA and list B, to Expected and Actual lists
cx-ricardo-jesus d6472f9
some changes on the json output
cx-ricardo-jesus 659c957
Merge branch 'master' of https://github.com/Checkmarx/kics into AST-1…
cx-ricardo-jesus 4ca9374
reverted changes on E2E results outputs
cx-ricardo-jesus 4e82a96
put listA and listB side by side
cx-ricardo-jesus 42d3978
fully implemented red line for diff line
cx-ricardo-jesus 0d2c48f
added queryName in the output
cx-ricardo-jesus 1a15c9d
final improvement on HTML E2E test results output
cx-ricardo-jesus 8511878
Merge branch 'master' into AST-131335
cx-ricardo-jesus 932225c
removed unnecessary comment
cx-ricardo-jesus a34adee
revert changes made on E2E fixtures
cx-ricardo-jesus 6790f60
reverted changes on E2E files
cx-ricardo-jesus e4e3ada
reverted changes on E2E files
cx-ricardo-jesus f321754
reverted changes on the wrong go template file
cx-ricardo-jesus 8683194
fixing go lint errors
cx-ricardo-jesus 5611d95
fixing go lint error
cx-ricardo-jesus 8ac97e6
go lint error fixing
cx-ricardo-jesus f877331
go lint error fixing
cx-ricardo-jesus cfe294f
go lint error fixing
cx-ricardo-jesus 7c28f4f
fixing go lint errors
cx-ricardo-jesus 46abb25
fixing go lint errors
cx-ricardo-jesus a3118ce
fixing go lint errors
cx-ricardo-jesus 8e80bfa
fixing go lint errors
cx-ricardo-jesus 8095708
fixing go lint errors
cx-ricardo-jesus 5d50ea6
fixing go lint errors
cx-ricardo-jesus 87ec694
keeping up with the codacy quality standards
cx-ricardo-jesus 05f3faf
improvements on the code
cx-ricardo-jesus a7749ec
trimmed lines before direct comparisons
cx-ricardo-jesus da5bb04
Merge branch 'master' into AST-131335
cx-ricardo-jesus edea662
adding the e2e-report file again
cx-ricardo-jesus 1b2f3de
changing google.golang.org/grpc version from 1.77.0 to 1.79.3
cx-ricardo-jesus 02ed209
fixed analyze command in e2e test
cx-ricardo-jesus 1ade1e3
covered FileStats field comparison on e2e tests
cx-ricardo-jesus be468c5
reverting changes made on analyze.go file
cx-ricardo-jesus 5c745a3
Merge branch 'master' into AST-131335
cx-ricardo-jesus 5a36c2a
changed moby/buildkit version from 0.26.3 to 0.28.1
cx-ricardo-jesus 5de7d74
revert changes
cx-ricardo-jesus a13922e
changed moby/buildkit version from 0.26.3 to 0.28.1
cx-ricardo-jesus abfe9bf
fixing unproperly formatted code
cx-ricardo-jesus d6f8fdd
fixed path
cx-ricardo-jesus dbabcc8
fixed unproperly formatted code
cx-ricardo-jesus fc03398
removed commented code
cx-ricardo-jesus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| github.com/cheekybits/is v0.0.0-20150225183255-68e9c0620927/go.mod h1:h/aW8ynjgkuj+NQRlZcDbAbM1ORAbXjXX77sX7T289U= | ||
| github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc= | ||
| github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk= | ||
| github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ= | ||
| github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA= | ||
| github.com/matryer/try v0.0.0-20161228173917-9ac251b645a2/go.mod h1:0KeJpeMD6o+O4hW7qJOT7vyQPKrWmj26uf5wMc/IiIs= | ||
| github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA= | ||
| github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg= | ||
| github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= | ||
| github.com/mattn/go-isatty v0.0.19 h1:JITubQf0MOLdlGRuRq+jtsDlekdYPia9ZFsB8h/APPA= | ||
| github.com/mattn/go-isatty v0.0.19/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= | ||
| github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= | ||
| github.com/rs/xid v1.5.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg= | ||
| github.com/rs/zerolog v1.31.0 h1:FcTR3NnLWW+NnTwwhFWiJSZr4ECLpqCm6QsEnyvbV4A= | ||
| github.com/rs/zerolog v1.31.0/go.mod h1:/7mN4D5sKwJLZQ2b/znpjC3/GQWY/xaDXUM0kKWRHss= | ||
| github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg= | ||
| github.com/tdewolff/minify/v2 v2.9.21 h1:nO4s1PEMy7aRjlIlbr3Jgr+bJby8QYuifa2Vs2f9lh4= | ||
| github.com/tdewolff/minify/v2 v2.9.21/go.mod h1:PoDBts2L7sCwUT28vTAlozGeD6qxjrrihtin4bR/RMM= | ||
| github.com/tdewolff/parse/v2 v2.5.19 h1:Kjaj3KQOx/4elIxlBSglus4E2oMfdROphvbq2b+OBZ0= | ||
| github.com/tdewolff/parse/v2 v2.5.19/go.mod h1:WzaJpRSbwq++EIQHYIRTpbYKNA3gn9it1Ik++q4zyho= | ||
| github.com/tdewolff/test v1.0.6 h1:76mzYJQ83Op284kMT+63iCNCI7NEERsIN8dLM+RiKr4= | ||
| github.com/tdewolff/test v1.0.6/go.mod h1:6DAvZliBAAnD7rhVgwaM7DE5/d9NMOAJ09SqYqeK4QE= | ||
| golang.org/x/sys v0.0.0-20191005200804-aed5e4c7ecf9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | ||
| golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.12.0 h1:CM0HF96J0hcLAwsHPJZjfdNzs0gftsLfgKt57wWHJ0o= | ||
| golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| github.com/cheekybits/is v0.0.0-20150225183255-68e9c0620927/go.mod h1:h/aW8ynjgkuj+NQRlZcDbAbM1ORAbXjXX77sX7T289U= | ||
| github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc= | ||
| github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk= | ||
| github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ= | ||
| github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA= | ||
| github.com/matryer/try v0.0.0-20161228173917-9ac251b645a2/go.mod h1:0KeJpeMD6o+O4hW7qJOT7vyQPKrWmj26uf5wMc/IiIs= | ||
| github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA= | ||
| github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg= | ||
| github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= | ||
| github.com/mattn/go-isatty v0.0.19 h1:JITubQf0MOLdlGRuRq+jtsDlekdYPia9ZFsB8h/APPA= | ||
| github.com/mattn/go-isatty v0.0.19/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= | ||
| github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= | ||
| github.com/rs/xid v1.5.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg= | ||
| github.com/rs/zerolog v1.31.0 h1:FcTR3NnLWW+NnTwwhFWiJSZr4ECLpqCm6QsEnyvbV4A= | ||
| github.com/rs/zerolog v1.31.0/go.mod h1:/7mN4D5sKwJLZQ2b/znpjC3/GQWY/xaDXUM0kKWRHss= | ||
| github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg= | ||
| github.com/tdewolff/minify/v2 v2.9.21 h1:nO4s1PEMy7aRjlIlbr3Jgr+bJby8QYuifa2Vs2f9lh4= | ||
| github.com/tdewolff/minify/v2 v2.9.21/go.mod h1:PoDBts2L7sCwUT28vTAlozGeD6qxjrrihtin4bR/RMM= | ||
| github.com/tdewolff/parse/v2 v2.5.19 h1:Kjaj3KQOx/4elIxlBSglus4E2oMfdROphvbq2b+OBZ0= | ||
| github.com/tdewolff/parse/v2 v2.5.19/go.mod h1:WzaJpRSbwq++EIQHYIRTpbYKNA3gn9it1Ik++q4zyho= | ||
| github.com/tdewolff/test v1.0.6 h1:76mzYJQ83Op284kMT+63iCNCI7NEERsIN8dLM+RiKr4= | ||
| github.com/tdewolff/test v1.0.6/go.mod h1:6DAvZliBAAnD7rhVgwaM7DE5/d9NMOAJ09SqYqeK4QE= | ||
| golang.org/x/sys v0.0.0-20191005200804-aed5e4c7ecf9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | ||
| golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.12.0 h1:CM0HF96J0hcLAwsHPJZjfdNzs0gftsLfgKt57wWHJ0o= | ||
| golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.