Graphcore changes for natspec/autoprove#18
Open
jtoman wants to merge 3 commits into
Open
Conversation
naftali-g
reviewed
May 24, 2026
|
|
||
|
|
||
| # Type alias for the user-facing ``global_exclude`` config. Both forms | ||
| # return True to *exclude* the path. The callable form (preferred) is |
Contributor
There was a problem hiding this comment.
I think it's confusing that _floor_include returns True if the path should be included, but the exclude returns True in the opposite case.
Comment on lines
+518
to
+521
| if replace_all: | ||
| new_content = cont.replace(old_string, new_string) | ||
| else: | ||
| new_content = cont.replace(old_string, new_string, 1) |
Contributor
There was a problem hiding this comment.
technically you don't need this if-else - you already know that there's just 1 occurrence when replace_all is False.
| return tool_output( | ||
| tool_call_id=tool_call_id, | ||
| res={ | ||
| "vfs": {norm_path: new_content}, |
Contributor
There was a problem hiding this comment.
so this tool saves on the number of tokens the llm produces to write the file, but it will still get the whole new file in the response?
| if cache_listing: | ||
| _list_all_files = cache(_list_all_files) | ||
| @dataclass | ||
| class DirBackend: |
Contributor
There was a problem hiding this comment.
you don't want this class to explicitly inherit FSBackend?
| { name = "langchain-anthropic", specifier = ">=1.4" }, | ||
| { name = "langchain-core", specifier = ">=1.2" }, | ||
| { name = "langgraph", specifier = "==1.1.0" }, | ||
| { name = "langgraph", specifier = "==1.0.5" }, |
| [[package]] | ||
| name = "langchain" | ||
| version = "1.2.11" | ||
| version = "1.2.6" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str_replaceused by claude code, codex, etc. Much more token efficient for targeted edits.gitdirectory or copy its contents during materializationfs_toolsis simply an instantiation of this new layered abstraction with a single "DirBackend".