Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to add Ruby 4.0 to the CI testing matrix. However, Ruby 4.0 has not been released as of December 2025, making this change problematic.
Key changes:
- Adds "4.0" to the base ruby-version matrix
- Replaces all Ruby 3.4 entries in the matrix includes with Ruby 4.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - ruby-version: "3.4" | ||
| - ruby-version: "4.0" | ||
| active-record-version-env: ACTIVE_RECORD_BRANCH="7-1-stable" | ||
| allow-failure: true |
There was a problem hiding this comment.
The matrix includes section appears to be replacing Ruby 3.4 configurations with Ruby 4.0. This creates a gap in testing coverage as Ruby 3.4 configurations are being removed rather than having Ruby 4.0 added as additional test cases. This means Ruby 3.4 will no longer be tested against these Active Record branches, which may not be the intended behavior.
Suggested change
| allow-failure: true | |
| allow-failure: true | |
| - ruby-version: "3.4" | |
| active-record-version-env: ACTIVE_RECORD_BRANCH="main" | |
| allow-failure: true | |
| - ruby-version: "3.4" | |
| active-record-version-env: ACTIVE_RECORD_BRANCH="8-1-stable" | |
| allow-failure: true | |
| - ruby-version: "3.4" | |
| active-record-version-env: ACTIVE_RECORD_BRANCH="8-0-stable" | |
| allow-failure: true | |
| - ruby-version: "3.4" | |
| active-record-version-env: ACTIVE_RECORD_BRANCH="7-2-stable" | |
| allow-failure: true | |
| - ruby-version: "3.4" | |
| active-record-version-env: ACTIVE_RECORD_BRANCH="7-1-stable" | |
| allow-failure: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.