Fix: remove fake apt packages blocking install on Linux#632
Merged
Conversation
…d only libonnxruntime-dev doesn't exist in Ubuntu repos. Was blocking install. ORT is already downloaded from GitHub releases to ~/.continuum/lib/ (no sudo).
Contributor
There was a problem hiding this comment.
Pull request overview
Removes attempts to install ONNX Runtime via apt on Linux/WSL, aligning the installer with the existing approach of downloading ONNX Runtime into user-space for Silero VAD support.
Changes:
- Removes the apt-based detection/installation of
libonnxruntime*packages on Linux/WSL. - Clarifies via comments that ONNX Runtime is handled later via GitHub release download rather than
needed[].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libonnxruntime-dev doesn't exist in Ubuntu repos. ORT downloads from GitHub to user-space instead.