Improve Superset auth error message on unexpected response shape#220
Merged
Conversation
When /api/v1/me/ returns valid JSON without a 'result' key (e.g. an error envelope from an expired session or a Superset error), the code crashed with KeyError: 'result' and dropped the response body. Add a guard mirroring the Content-Type check above so the actual response text surfaces in logs.
dmarulli
requested review from
christophertull,
jin-current,
mdowell12 and
pat-current
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
/api/v1/me/returns valid JSON without aresultkey, the code crashed withKeyError: 'result'and dropped the response body. Adds a guard mirroring the Content-Type check above so the actual response text surfaces in logs.Context
cadc_crescent-ami-meter-read-dag-standardfailed on 2026-04-29 withKeyError: 'result'atxylem_datalake.py:193. Root cause is unknown because the error swallowed the response. Likely candidates: expired Keycloak session, rate-limit, or Superset error envelope. This change makes future occurrences self-diagnosing.Test plan