fix(cookies): avoid banner wrapper blocking clicks#1327
fix(cookies): avoid banner wrapper blocking clicks#1327powerfullz wants to merge 1 commit intoCaiJimmy:masterfrom
Conversation
|
Thanks for fixing my mistake here, to not duplicate work, did you already attempt to fix this in #1308? |
No, I didn't touch the CSS in #1308. That PR was entirely focused on refactoring the code logic to strictly comply with the spirit of GDPR. The previous approach loaded the comment scripts upfront and simply covered the comment area with a mask, which might still fail to prevent some comment systems from dropping cookies in the background. #1308 fixed this by ensuring that the comment scripts are only loaded and the comment system is enabled after the user explicitly gives consent. Btw, I've already merged all my upstream PRs into my own fork. If you'd like to see these changes in action, feel free to drop by my blog |
Currently, the wrapper of the cookie consent banner captures user clicks, making elements such as the dark mode toggle unclickable when the banner pops up.
This pull request makes a small but important update to the cookie banner's styling to improve user interaction. The main change ensures that only the visible cookie banner content is interactive, allowing users to click elements not covered by the banner.
assets/scss/partials/cookies.scss: Setspointer-events: noneon the cookie banner container to prevent interaction with hidden or background areas, and enablespointer-events: autoon the banner content so users can interact with visible elements. [1] [2]