Skip to content

fix(security): defense-in-depth hardening for plugin_wmi #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
somethingwithproof wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix(security): defense-in-depth hardening for plugin_wmi #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af940c2
fix(security): defense-in-depth hardening for plugin_wmi
somethingwithproof Apr 9, 2026
3bdd884
fix(ci): Dependabot composer ecosystem, CodeQL PHP coverage
somethingwithproof Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.git*

locales/po/*.mo
.omc/
2 changes: 1 addition & 1 deletion linux_wmi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ function retrieve_account() {

function decode($info) {
$info = base64_decode($info);
$info = unserialize($info);
$info = unserialize($info, array('allowed_classes' => false));
$info = $info['password'];
Comment on lines 291 to 293
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unserialize() (even with allowed_classes => false) and base64_decode() can return false on malformed/corrupt data. Immediately indexing $info['password'] will raise warnings/notices and may break authentication flow. Consider validating that the decoded/unserialized value is an array with the expected key (and returning a safe failure / setting $this->error) when decoding fails.

Copilot uses AI. Check for mistakes.

return $info;
Expand Down