Constrain MAC-filled values to the variable's range#450
Merged
Conversation
Member
Author
|
If this looks good to you @stephpenn1 , and assuming tests pass, I will re-run L2 and upload to the HPC. |
stephpenn1
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the L2 step we add a
Value_MACcolumn based on each variable's mean annual cycle, and it was possible for these imputed values to be nonsensical -- see example posted by @stephpenn1 in #433 .This PR ensures that our MAC values are not allowed to drift outside of the variable's bounds defined in
metadata/variables_metadata.csv; we truncate to that range.Result for Steph's example:
Closes #433