bug: Add missing text field in Administered Medications #1401
Open
vochaparro2 wants to merge 17 commits intomainfrom
Open
bug: Add missing text field in Administered Medications #1401vochaparro2 wants to merge 17 commits intomainfrom
text field in Administered Medications #1401vochaparro2 wants to merge 17 commits intomainfrom
Conversation
vochaparro2
requested review from
angelathe and
austin-hall-skylight
and removed request for
a team
6 tasks
# Conflicts: # containers/ecr-viewer/src/app/utils/evaluate/index.ts # containers/ecr-viewer/src/app/view-data/components/EcrDocument/accordion-items.tsx # containers/ecr-viewer/src/app/view-data/page.tsx # containers/ecr-viewer/src/app/view-data/services/ecrSummaryService.tsx # containers/ecr-viewer/src/app/view-data/services/fhirResourcesIndexService.tsx # containers/ecr-viewer/src/app/view-data/services/labsService.tsx # containers/ecr-viewer/tests/unit/app/utils/evaluate.test.ts # containers/ecr-viewer/tests/unit/app/view-data/components/LabInfo.test.tsx # containers/ecr-viewer/tests/unit/app/view-data/services/fhirResourcesIndexService.test.tsx # containers/ecr-viewer/tests/unit/app/view-data/services/labsService.test.tsx # containers/fhir-converter/Dockerfile
…nto laura-victor/1345-dosage-text
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
+ Coverage 86.29% 86.35% +0.05%
==========================================
Files 258 249 -9
Lines 11488 11003 -485
Branches 1284 1308 +24
==========================================
- Hits 9914 9502 -412
+ Misses 1567 1494 -73
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laura-puerto-skylight
approved these changes
Mar 31, 2026
Collaborator
laura-puerto-skylight
left a comment
laura-puerto-skylight
left a comment
There was a problem hiding this comment.
LGTM! Don't forget to update the Dockerfile to a release tag before merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Administered Medications section to add the missing Text field.
Related Issue
Fixes #1345
Acceptance Criteria
Additional Information
Anything else the review team should know?
Checklist