Skip to content

feat: Adding social determinants of health questionnaire#1354

Open
laura-puerto-skylight wants to merge 5 commits intomainfrom
laura/sdoh
Open

feat: Adding social determinants of health questionnaire#1354
laura-puerto-skylight wants to merge 5 commits intomainfrom
laura/sdoh

Conversation

@laura-puerto-skylight
Copy link
Copy Markdown
Collaborator

Summary

Initial UI for the Social Determinants of Health Questionnaire:
image

Related Issue

Fixes #1226

Acceptance Criteria

eCR Viewer

  • Add social history questions to the eCR Viewer
  • Update test fixtures/unit tests

Additional Information

FHIR Converter PR: CDCgov/dibbs-FHIR-Converter#117

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.37%. Comparing base (057a468) to head (4a16923).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   86.29%   86.37%   +0.07%     
==========================================
  Files         258      249       -9     
  Lines       11488    11031     -457     
  Branches     1284     1292       +8     
==========================================
- Hits         9914     9528     -386     
+ Misses       1567     1496      -71     
  Partials        7        7              
Flag Coverage Δ
ecr-viewer 92.04% <100.00%> (+0.04%) ⬆️
ingestion 61.49% <ø> (ø)
message-parser 96.00% <ø> (ø)
orchestration 85.29% <ø> (ø)
trigger-code-reference ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are meant to allow the question text to use the full width instead of being squished to the side which looked weird for longer questions. I am still waiting on designs so this might change further.

@laura-puerto-skylight laura-puerto-skylight marked this pull request as ready for review March 17, 2026 23:40
@laura-puerto-skylight laura-puerto-skylight requested a review from a team as a code owner March 17, 2026 23:40
@angelathe
Copy link
Copy Markdown
Collaborator

Adding a note for myself here to check if anything needs to change in message-parser (ex. homelessness status)?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I wonder if we can actually make a V2 of dash-rendar to add to the seed data, rather than editing the original?

Maybe we could call it dash-rendar-SODH?
It would need a new ``->`, but for versioning, it should share the same `setId` as dash-rendar, and have a +1 `versionNumber`

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "it would need a new ``->`," you mean a new id?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just writing a comment to make sure this gets updated if anything changes in the FHIR converter

# Download FHIR-Converter

RUN git clone https://github.com/CDCgov/dibbs-FHIR-Converter.git --branch 8.0.3 --depth 1 /App
RUN git clone https://github.com/CDCgov/dibbs-FHIR-Converter.git --branch laura/sdoh --depth 1 /App
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obligatory TODO to change this when FHIR converter PR goes in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UAT: Add social history questionnaire to eCR Viewer

3 participants