Fix header error for permanentToken #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getRequestOptions for Oauth2 and PermanentToken
Contributor
|
@ConstantBqt heads up regarding your PR #82, sounds like these changes should be used. |
Contributor
|
@ConstantBqt as a follow up can you check to see if these changes suffice in comparison to your original PR for #82? |
Contributor
|
Hi @ahongbynder, Thanks |
ahongbynder
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is following #65 to be more versatile and work in any cases.
The
$optionsarray passed to thesendAuthenticatedRequestshould not be used as request options.Instead I changed the way authorization header was set to be more like the OAuth2 implementation.
This PR also standardize how
requestOptions(and user-agent header) is set to be the same across the 2 implementations.This PR should be used instead of #82