Skip to content

Conversation

@ConstantBqt
Copy link
Contributor

Create 5 new function to use missing endpoints

  • createMetaPropertyOption
  • modifyMetaPropertyOption
  • getSingleMetaPropertyOptions
  • syncAssetUsage
  • getAccount

Update Request handler to fix an issue with json requests (Sync asset usage)

@coveralls
Copy link

coveralls commented Jan 25, 2024

Coverage Status

coverage: 46.839% (-1.2%) from 48.083%
when pulling 39c1020 on ConstantBqt:add_new_api_endpoints
into 3b885e1 on Bynder:master.

Copy link

@dylanmartins dylanmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ConstantBqt Hey I see that the coverage decreased a bit, could you create some tests to cover these new calls?

Thanks!

@ConstantBqt
Copy link
Contributor Author

Hi @dylanmartins,
I have just added the PHP unit tests.
Thanks

@ConstantBqt ConstantBqt requested a review from dylanmartins March 1, 2024 16:12
@dylanmartins
Copy link

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

@ConstantBqt
Copy link
Contributor Author

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

My bad, I didn't push it 😅
Thanks

@ConstantBqt
Copy link
Contributor Author

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

Hi @dylanmartins,
I have updated the code with the tests. Is there anything else I can do ?
Thanks

protected function sendAuthenticatedRequest($requestMethod, $uri, $options = [])
{
$request = new \GuzzleHttp\Psr7\Request($requestMethod, $uri, $options);
$headers = array_filter($options, function ($key) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same kind of filter for form_params in #65
I guess there might be other key to remove here too..

- createMetaPropertyOption
- modifyMetaPropertyOption
- syncAssetUsage
- getAccount
@ConstantBqt ConstantBqt force-pushed the add_new_api_endpoints branch from 5ea6842 to a0e3a63 Compare March 25, 2025 09:42
@ConstantBqt ConstantBqt changed the title Implement 5 missing API endpoints Implement 4 missing API endpoints Mar 25, 2025
@ConstantBqt
Copy link
Contributor Author

Hi, I rebased the branch and removed the duplicated endpoint.

@ahongbynder ahongbynder merged commit f97cf68 into Bynder:master Mar 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants