-
Notifications
You must be signed in to change notification settings - Fork 21
Implement 4 missing API endpoints #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dylanmartins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConstantBqt Hey I see that the coverage decreased a bit, could you create some tests to cover these new calls?
Thanks!
|
Hi @dylanmartins, |
|
@ConstantBqt sorry for the late answer, did you push the commit with the tests? |
My bad, I didn't push it 😅 |
Hi @dylanmartins, |
| protected function sendAuthenticatedRequest($requestMethod, $uri, $options = []) | ||
| { | ||
| $request = new \GuzzleHttp\Psr7\Request($requestMethod, $uri, $options); | ||
| $headers = array_filter($options, function ($key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the same kind of filter for form_params in #65
I guess there might be other key to remove here too..
- createMetaPropertyOption - modifyMetaPropertyOption - syncAssetUsage - getAccount
5ea6842 to
a0e3a63
Compare
|
Hi, I rebased the branch and removed the duplicated endpoint. |
Create 5 new function to use missing endpoints
Update Request handler to fix an issue with json requests (Sync asset usage)