Skip to content

Added share support for twitter mobile #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sir-radar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added share support for twitter mobile #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25d7e9
Added share support for twitter mobile
sir-radar Mar 5, 2024
c53bb24
Added share support for twitter mobile
sir-radar Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ import {
| via | string | | | ❌ |
| hashtags | array | | | ❌ |
| related | array | | | ❌ |
| isMobile | boolean | false | Supports twitter share for mobile if set to `true` | ❌ |
| windowWidth | number | 550 | Opened window width. | ❌ |
| windowHeight | number | 400 | Opened window height. | ❌ |
| blankTarget | boolean | false | Open share window in a new tab if set to `true`. | ❌ |
Expand Down Expand Up @@ -1089,4 +1090,4 @@ export default class Sticky extends Component<Props> {
}
}

====================== -->
====================== -->
15 changes: 13 additions & 2 deletions src/components/buttons/TwitterShareButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,19 @@ function twitterLink(
via,
hashtags = [],
related = [],
}: { title?: string; via?: string; hashtags?: string[]; related?: string[] },
isMobile = false,
}: {
title?: string;
via?: string;
hashtags?: string[];
related?: string[];
isMobile?: boolean;
},
) {
return (
'https://twitter.com/intent/tweet' +
(isMobile
? 'https://mobile.twitter.com/intent/tweet'
: 'https://twitter.com/intent/tweet') +
transformObjectToParams({
url,
text: title,
Expand All @@ -27,6 +36,7 @@ const TwitterShareButton = createShareButton<{
via?: string;
hashtags?: string[];
related?: string[];
isMobile?: boolean;
}>(
'twitter',
twitterLink,
Expand All @@ -35,6 +45,7 @@ const TwitterShareButton = createShareButton<{
title: props.title,
via: props.via,
related: props.related,
isMobile: props.isMobile,
}),
{
windowWidth: 550,
Expand Down