fix: use solid window background on Windows#3
Open
StDensity wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows window background so Glyph no longer appears transparent when using dark mode. The macOS translucent/glass-style background is preserved, while non-macOS platforms use the solid theme background color.
Type of change
Linked issues
Closes #1
Testing notes
Reviewed the UI background logic in
src/App.tsxand confirmed that non-macOS platforms now usebg-background, which maps to the configured light/dark theme colors.Manual Windows verification still recommended:
pnpm tauri:devon Windows.Ctrl+B.Pre-merge checklist
pnpm exec tsc --noEmitpassespnpm lintpassescd src-tauri && cargo checkpassescd src-tauri && cargo clippy --all-targetspasses (no new warnings)pnpm tauri:devsrc-tauri/capabilities/default.jsonNotes for reviewers