Skip to content

fix(stencil): TS error on attribute passing - #1810

Open
mfranzke wants to merge 4 commits into
BuilderIO:mainfrom
mfranzke:mfranzke-patch-6
Open

fix(stencil): TS error on attribute passing#1810
mfranzke wants to merge 4 commits into
BuilderIO:mainfrom
mfranzke:mfranzke-patch-6

Conversation

@mfranzke

@mfranzke mfranzke commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Please provide the following information:

What changes you made

Changed [...parent.attributes]Array.from(parent.attributes). Array.from is correctly typed to accept array-like objects (which NamedNodeMap is) without needing DOM.Iterable.

Why you made them

In packages/core/src/helpers/web-components/attribute-passing.ts, the generated code uses [...parent.attributes] (spread on NamedNodeMap). TypeScript requires DOM.Iterable in the lib compiler option for this to type-check.

Any other useful context

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@mfranzke
mfranzke requested a review from samijaber as a code owner July 23, 2026 05:40
@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2ae9f24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud

nx-cloud Bot commented Jul 23, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 1a4141f

Command Status Duration Result
nx run-many --target test ✅ Succeeded 5m 6s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 33s View ↗
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 11s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-23 05:50:14 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant