Pin npm toolchain - #31
Merged
Merged
Conversation
foundev
marked this pull request as ready for review
August 3, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install,ci, andruncommands throughdevEnginesnpm ciWhy
PR #30 exposed a cross-major npm lockfile rewrite: npm 11 removed Vitest's required nested esbuild 0.28.1 platform packages, while the Node 22 CI environment rejected that lockfile. Regenerating with npm 10 fixed the immediate lockfile, but without a toolchain pin the next npm 11 dependency update could recreate the failure.
packageManagerdocuments the selected tool, whiledevEnginesprevents a mismatched npm from mutating the project. The workflow setup makes CI independent of whichever npm minor ships with Node 22.Validation
EBADDEVENGINESbefore lockfile mutationnpm ciwith npm 10.9.4npm testnpm cijobs pin npm 10.9.4git diff --cached --check