Fixes for part assignment, order by Stock by default DESC#709
Open
larroy wants to merge 3 commits intoBouni:mainfrom
Open
Fixes for part assignment, order by Stock by default DESC#709larroy wants to merge 3 commits intoBouni:mainfrom
larroy wants to merge 3 commits intoBouni:mainfrom
Conversation
andy9a9
reviewed
Mar 28, 2026
| @@ -1 +1 @@ | |||
| {"partselector": {"basic": false, "extended": false, "preferred": true, "stock": false}, "gerber": {"tented_vias": true, "fill_zones": false, "plot_values": true, "plot_references": true, "lcsc_bom_cpl": true}, "general": {"lcsc_priority": false, "order_number": true}} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I would say this shouldn't touched here
| fp.SetField("LCSC", lcsc) | ||
| field = fp.GetFieldByName("LCSC") | ||
| field.SetVisible(False) | ||
| if hasattr(fp, "GetFieldByName"): |
Contributor
There was a problem hiding this comment.
What happens if there is no attribute? I created my own fix #711 as I haven't realized, that this exist. Either use mine or fix this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assigning parts, I had to click twice, turns out there was an exception when looking for the LCSC attribute, which seems is not set instantly.