Skip to content

Map the Vorbis DESCRIPTION, ORGANIZATION and PUBLISHER fields - #2688

Open
MildlyMeticulous wants to merge 1 commit into
Borewit:masterfrom
MildlyMeticulous:fix/vorbis-description-mapping
Open

Map the Vorbis DESCRIPTION, ORGANIZATION and PUBLISHER fields#2688
MildlyMeticulous wants to merge 1 commit into
Borewit:masterfrom
MildlyMeticulous:fix/vorbis-description-mapping

Conversation

@MildlyMeticulous

Copy link
Copy Markdown

FFmpeg writes the comment and publisher fields into Vorbis comments as DESCRIPTION and PUBLISHER, neither of which is mapped, so both are dropped from common:

wide.flac   DESCRIPTION=Wide Comment   PUBLISHER=Wide Label
            common.comment  undefined
            common.label    undefined

DESCRIPTION and ORGANIZATION are both in the Ogg Vorbis comment field recommendations. PUBLISHER is not, but it is what FFmpeg writes, and track:PUBLISHER is already mapped to label in MatroskaTagMapper.

Vorbis common
DESCRIPTION comment
ORGANIZATION label
PUBLISHER label

Added a 4.8 kB test/samples/ogg/vorbis-description.ogg. 587 passing; reverting VorbisTagMapper.ts fails the new test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant