test: add unit tests for abiEncodeClearValues ebool and eaddress paths#4
Closed
luchobonatti wants to merge 1 commit intomainfrom
Closed
test: add unit tests for abiEncodeClearValues ebool and eaddress paths#4luchobonatti wants to merge 1 commit intomainfrom
luchobonatti wants to merge 1 commit intomainfrom
Conversation
Export abiEncodeClearValues as @internal to enable unit testing. Add 5 tests covering ebool true/false/invalid and eaddress encoding, plus a euint32 regression. Closes zama-ai#353
There was a problem hiding this comment.
Pull request overview
Adds unit coverage for abiEncodeClearValues edge paths in the relayer public decrypt flow, ensuring correct ABI-ready value formatting for ebool/eaddress and preventing a euint32 regression.
Changes:
- Export
abiEncodeClearValuesfromsrc/relayer/publicDecrypt.tswith@internalto enable direct unit testing. - Add 5 unit tests covering
ebooltrue/false/invalid,eaddressbigint formatting, and aneuint32pass-through regression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/relayer/publicDecrypt.ts | Exposes abiEncodeClearValues as an @internal export for test access. |
| src/relayer/publicDecrypt.test.ts | Adds a focused abiEncodeClearValues test suite for previously untested type paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closing — upstream PR zama-ai#356 already addresses this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes zama-ai#353
Summary
abiEncodeClearValuesfrompublicDecrypt.tswith@internalto enable unit testingeboolandeaddresscode paths, plus aeuint32regressionChanges
src/relayer/publicDecrypt.tsabiEncodeClearValueswith@internalannotationsrc/relayer/publicDecrypt.test.tsdescribe('abiEncodeClearValues')block with 5 unit testsTest plan
tsc --noEmitpassespublicDecrypt.test.tspass (8 pre-existing + 5 new)true→abiValues[0] === 1nfalse→abiValues[0] === 0n2n→ throws with correct messageabiValues42npasses through unchanged (regression)