Skip to content

Fix share contact for macOS 12+#45

Draft
JUSTINMKAUFMAN wants to merge 10 commits into
BlueBubblesApp:masterfrom
JUSTINMKAUFMAN:master
Draft

Fix share contact for macOS 12+#45
JUSTINMKAUFMAN wants to merge 10 commits into
BlueBubblesApp:masterfrom
JUSTINMKAUFMAN:master

Conversation

@JUSTINMKAUFMAN

Copy link
Copy Markdown
Contributor

Code was falling through to macOS 10 block for macOS 12 and higher.

@zlshames

Copy link
Copy Markdown
Member

Hey @JUSTINMKAUFMAN i would like to merge some of this in, but there's also a lot of extraneous files. For instance, some of your project configurations & paths as well as some of your Pod data files

@s0urfruit

Copy link
Copy Markdown

just wanted to check in 👀

@tneotia

tneotia commented May 6, 2026

Copy link
Copy Markdown
Member

I went ahead and cherry picked the initial commit and reason for opening the PR (fixing share contact). I definitely would like to look through the rest, but it's difficult to follow with the amount of commits and number of files changed. If possible, submitting seperate PRs with only changes for one specific feature/bugfix would be much appreciated.

I am going through the entire bundle and rewriting it (with proper support for Tahoe), so I will verify the cherry-picked changes and (likely) change the implementations to align with better code quality overall. Thanks for the contribution!

Reverting this to draft status for now in case you have time to revisit.

@tneotia tneotia marked this pull request as draft May 6, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants