Reduce package size by excluding unused 'deps' directory#1125
Open
shayff wants to merge 1 commit intoBlizzard:masterfrom
Open
Reduce package size by excluding unused 'deps' directory#1125shayff wants to merge 1 commit intoBlizzard:masterfrom
shayff wants to merge 1 commit intoBlizzard:masterfrom
Conversation
The 'deps' directory in the node-rdkafka package is significantly large (around 98MB), constituting roughly 83% of the total package size. Seems like removing that directory is not affect the functionality. This pull request proposes removing the 'deps' directory to decrease the package size. **File size breakdown (before this change):** Files: 24K ./bench 88K ./test 16K ./util 24K ./ci 32K ./examples 128K ./lib 98M ./deps 18M ./build 76K ./e2e 264K ./src 118M .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'deps' directory in the node-rdkafka package is significantly large (around 98MB), constituting roughly 83% of the total package size. Seems like removing that directory is not affect the functionality.
This pull request proposes removing the 'deps' directory to decrease the package size.
File size breakdown (before this change):
Files:
24K ./bench
88K ./test
16K ./util
24K ./ci
32K ./examples
128K ./lib
98M ./deps
18M ./build
76K ./e2e
264K ./src
118M .