fix(js): resolve daemon path for global npm symlinks - #2
Open
kuopenx-agent wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix daemon startup when
camoufox-cliis installed globally vianpm install -gor used vianpm link.When installed globally, the
camoufox-cliexecutable is typically a symlink todist/cli.js. The previous implementation deriveddaemon.jsfromimport.meta.urldirectly, which can resolve relative to the symlink location instead of the realdist/directory. Also, the CLI entrypoint check only matched paths ending in/cli.jsor/cli.ts, so a symlinked executable like.../bin/camoufox-cliwould not callmain()at all.Together, these issues can cause the daemon to fail to start or the CLI to silently exit with no output.
Closes #1.
Changes
fs.realpathSync(fileURLToPath(import.meta.url))daemon.jsfrom the resolved real pathprocess.argv[1]against the module pathDaemon (Node.js)instead ofDaemon (Python)Validation
npm --prefix js testnpm --prefix js run build