check array count in MenuGetter#33
Open
occludedpixel wants to merge 1 commit intoBenziAhamed:masterfrom
Open
Conversation
check array count to avoid index out of range error
|
@BenziAhamed is this repo actively maintained? The OmniGraffle bug was killing me until I had the thought to check github and found this perfect fix. This PR has been open for over a year though! Might you consider adding @occludedpixel as a collaborator so they could keep the workflow updated? I should also say, thank you for your work on this WF, which is probably the most useful one I have (and I have many!) |
|
As a fellow beleaguered open source maintainer I don't want to hassle you @BenziAhamed , but I can confirm that this fixes the issue and I'd love to get it merged so I'm not running a fork. |
|
Accidentally found this today! Also would love to see this merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an app that had a menu bar item with an empty kAXChildrenAttribute. Added a check to ensure that the array is non-empty to prevent an index out of range error when trying to access the first element.