fix(themes/powerline): restore POWERLINE_PROMPT_FOREGROUND_COLOR support#2384
Open
seefood wants to merge 3 commits intoBash-it:masterfrom
Open
fix(themes/powerline): restore POWERLINE_PROMPT_FOREGROUND_COLOR support#2384seefood wants to merge 3 commits intoBash-it:masterfrom
seefood wants to merge 3 commits intoBash-it:masterfrom
Conversation
The cleanup in Bash-it#2360 overwrote the fix from Bash-it#2231, causing POWERLINE_PROMPT_FOREGROUND_COLOR to be ignored. Restore the variable with a safe default of '-' (no override) so existing setups are unaffected while still allowing foreground color customization. Fixes Bash-it#2374 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…D_COLOR Covers the regression from Bash-it#2374: verifies that the fg color code is absent when the variable is unset and present when it is set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…bles Variables like SEGMENTS_AT_LEFT, LAST_SEGMENT_COLOR, and POWERLINE_PROMPT_FOREGROUND_COLOR are assigned in test setup/body and read by the loaded powerline functions; shellcheck can't see that cross- file usage and emits false-positive SC2034 warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POWERLINE_PROMPT_FOREGROUND_COLORsupport inpowerlineandpowerline-plainthemesset_color "${POWERLINE_PROMPT_FOREGROUND_COLOR}"back toset_color -(no foreground color)${POWERLINE_PROMPT_FOREGROUND_COLOR:--}so the default is-(terminal default fg, same as before) and the variable is only applied when explicitly set — prevents passing an empty string toset_colorwhich would generate a broken ANSI escapeTest plan
export POWERLINE_PROMPT_FOREGROUND_COLOR=15and verify bright-white foreground is applied across all powerline segmentsPOWERLINE_PROMPT_FOREGROUND_COLORand verify prompt renders identically to before (no regression)powerline-plaintheme has the same behaviourFixes #2374
🤖 Generated with Claude Code