Skip to content

Serialize xs:double/xs:float negative zero as -0 #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristianGruen merged 1 commit into from
Apr 21, 2026
Merged

Serialize xs:double/xs:float negative zero as -0 #2639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion basex-core/src/main/java/org/basex/io/serial/json/JsonSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ protected void atomic(final Item item) throws IOException {
if(type.oneOf(BasicType.DOUBLE, BasicType.FLOAT) || canonical && type.isNumber()) {
final double d = item.dbl(null);
if(Double.isFinite(d)) {
out.print(Dbl.string(d));
final byte[] s = Dbl.string(d);
out.print(canonical && s == NEGATIVE_ZERO ? token(0) : s);
} else {
if(canonical) throw SERNUMBER_X.getIO(d);
out.print(d == Double.POSITIVE_INFINITY ? JsonConstants.INF :
Expand Down
2 changes: 1 addition & 1 deletion basex-core/src/main/java/org/basex/query/value/item/Dbl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public static double parse(final byte[] value, final InputInfo info) throws Quer
*/
public static byte[] string(final double value) {
// handle known edge cases
if(value == 0) return Token.token(0);
if(value == 0) return 1 / value > 0 ? Token.token(0) : Token.NEGATIVE_ZERO;
if(value == Double.MIN_VALUE) return Token.token("5e-324");
if(value == -Double.MIN_VALUE) return Token.token("-5e-324");
if(value == 1e23) return Token.token("1e+23");
Expand Down
1 change: 1 addition & 0 deletions basex-core/src/test/java/org/basex/io/serial/json/BaseXSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public final class BaseXSerializerTest extends SandboxTest {
serialize("()", "");
serialize("1", "1");
serialize("1, 2", "1\n2");
serialize("xs:double('-0'), xs:float('-0')", "-0\n-0");

// nodes
serialize("<x/>", "<x/>");
Expand Down
11 changes: 10 additions & 1 deletion basex-core/src/test/java/org/basex/io/serial/json/JsonSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ public final class JsonSerializerTest extends SandboxTest {
final JsonFormat format = JsonFormat.DIRECT;
serialize("'x'", "'x'", format);
serialize("1", "1", format);
serialize("xs:double('-0')", "-0", format);
serialize("xs:float('-0')", "-0", format);
serialize("true()", "true", format);
serialize("<_/>", "'<_\\/>'", format);

Expand Down Expand Up @@ -64,6 +66,8 @@ public final class JsonSerializerTest extends SandboxTest {
final JsonFormat format = JsonFormat.ATTRIBUTES;
serialize("'x'", "'x'", format);
serialize("1", "1", format);
serialize("xs:double('-0')", "-0", format);
serialize("xs:float('-0')", "-0", format);
serialize("true()", "true", format);
serialize("<_/>", "'<_\\/>'", format);

Expand Down Expand Up @@ -116,6 +120,8 @@ public final class JsonSerializerTest extends SandboxTest {
serialize("{ 'A': false() }", "{'A':false}", format);
serialize("{ true(): false() }", "{'true':false}", format);
serialize("{ 1: 'E' }", "{'1':'E'}", format);
serialize("{ 0: xs:double('-0') }", "{'0':-0}", format);
serialize("{ 0: xs:float('-0') }", "{'0':-0}", format);

serialize("{ 'A': 1 div 0.0e0 }", "{'A':1e9999}", format);
serialize("{ 'A': -1 div 0.0e0 }", "{'A':-1e9999}", format);
Expand All @@ -129,6 +135,8 @@ public final class JsonSerializerTest extends SandboxTest {
serialize("[ 2 ]", "[2]", format);
serialize("[ 2, 3 ]", "[2,3]", format);
serialize("[ 2, (), 4 ]", "[2,null,4]", format);
serialize("[ xs:double('-0') ]", "[-0]", format);
serialize("[ xs:float('-0') ]", "[-0]", format);

error("[ (1, 2) ]", format, SERJSONSEQ);

Expand All @@ -146,7 +154,8 @@ public final class JsonSerializerTest extends SandboxTest {
serialize("1", "1", format);

serialize("0.0e0", "0", format);
serialize("-0.0e0", "0", format);
serialize("-0.0e0", "-0", format);
serialize("xs:float('-0')", "-0", format);
serialize("1e-6", "0.000001", format);
serialize("1e-7", "1e-7", format);
serialize("1e20", "100000000000000000000", format);
Expand Down
6 changes: 6 additions & 0 deletions basex-core/src/test/java/org/basex/query/SerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ public final class SerializerTest extends SandboxTest {
query(option + "1234567890e0", "1.23456789e9");
query(option + "xs:double('NaN')", "NaN");
query(option + "xs:double('INF')", "INF");
query(option + "xs:double('-0')", "-0.0e0");
query(option + "xs:byte(1)", 1);
query(option + "false()", "false()");
query(option + "'A'", "\"A\"");
Expand All @@ -273,6 +274,7 @@ public final class SerializerTest extends SandboxTest {
query(option + "true#0", "fn:true#0");
query(option + "fn() {}", "fn() as empty-sequence() { () }");
query(option + "xs:float(1)", "xs:float(\"1\")");
query(option + "xs:float('-0')", "xs:float(\"-0\")");

query(option + "[]", "[]");
query(option + "[ 1 ]", "[1]");
Expand All @@ -281,6 +283,7 @@ public final class SerializerTest extends SandboxTest {
query(option + "[ 1234567890e0 ]", "[1.23456789e9]");
query(option + "[ xs:double('NaN') ]", "[NaN]");
query(option + "[ xs:double('INF') ]", "[INF]");
query(option + "[ xs:double('-0') ]", "[-0.0e0]");
query(option + "[ xs:byte(1) ]", "[1]");
query(option + "[ false() ]", "[false()]");
query(option + "[ 'A' ]", "[\"A\"]");
Expand All @@ -292,6 +295,7 @@ public final class SerializerTest extends SandboxTest {
query(option + "[ true#0 ]", "[fn:true#0]");
query(option + "[ fn() {} ]", "[fn() as empty-sequence() { () }]");
query(option + "[ xs:float(1) ]", "[xs:float(\"1\")]");
query(option + "[ xs:float('-0')]", "[xs:float(\"-0\")]");

query(option + "{ 1: (), 2: 3, 4: (5, 6) }", "{1:(),2:3,4:(5,6)}");
}
Expand All @@ -305,6 +309,7 @@ public final class SerializerTest extends SandboxTest {
query("1234567890e0", 1234567890);
query("xs:double('NaN')", "NaN");
query("xs:double('INF')", "INF");
query("xs:double('-0')", "-0");
query("xs:byte(1)", 1);
query("false()", "false");
query("'A'", "A");
Expand All @@ -316,6 +321,7 @@ public final class SerializerTest extends SandboxTest {
query("true#0", "fn:true#0");
query("fn() {}", "fn() as empty-sequence() { () }");
query("xs:float(1)", 1);
query("xs:float('-0')", "-0");

query("[]", "[]");
query("[ 1 ]", "[1]");
Expand Down
2 changes: 1 addition & 1 deletion basex-core/src/test/java/org/basex/query/func/BinModuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ public final class BinModuleTest extends SandboxTest {
query(func.args(hex("0000000000000000"), 0), 0);
query(func.args(hex("3FF0000000000000"), 0), 1);
query(func.args(hex("BFF0000000000000"), 0), -1);
query(func.args(hex("8000000000000000"), 0), 0);
query(func.args(hex("8000000000000000"), 0), "-0");
query(func.args(hex("0000000000000000"), 0), 0);
query(func.args(hex("7FF0000000000000"), 0), "INF");
query(func.args(hex("FFF0000000000000"), 0), "-INF");
Expand Down
4 changes: 4 additions & 0 deletions basex-core/src/test/java/org/basex/query/func/FnModuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,6 +3189,8 @@ public final class FnModuleTest extends SandboxTest {

final String canonicalJson = " {'method': 'json', 'canonical': true()}";
query(func.args(" [0x7fff_ffff_ffff_ffff]", canonicalJson), "[9223372036854776000]");
query(func.args(" [xs:double('-0')]", " {'method': 'json'}"), "[-0]");
query(func.args(" [xs:double('-0')]", canonicalJson), "[0]");

// The tests below were adapted from Apache 2.0–licensed code from project
// erdtman/java-json-canonicalization at https://github.com/erdtman/java-json-canonicalization
Expand Down Expand Up @@ -3436,6 +3438,8 @@ public final class FnModuleTest extends SandboxTest {
query(func.args("A"), "A");
query(func.args(wrap("A")), "A");
query("(" + wrap("A") + ", 1, 'X') ! " + func.args(), "A\n1\nX");
query(func.args(" xs:float('-0')"), "-0");
query(func.args(" xs:double('-0')"), "-0");

check("for $s in ('a', 'b') return " + func.args(" $s"), "a\nb", empty(func));
check("for $s in (<a/>, <b/>) return " + func.args(" $s"), "\n", exists(func));
Expand Down
2 changes: 1 addition & 1 deletion basex-core/src/test/java/org/basex/query/func/JsonModuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public final class JsonModuleTest extends SandboxTest {
query(func.args("0E1", options), 0);
query(func.args("0E-1", options), 0);
query(func.args("0E+1", options), 0);
query(func.args("-0E+1", options), "0");
query(func.args("-0E+1", options), "-0");
query(func.args("0E00", options), 0);
query(func.args("123e-123", options), "1.23e-121");
query(func.args("123.4e-123", options), "1.234e-121");
Expand Down
Loading