refactor: split large controllers and components into focused modules#7
Merged
Conversation
Backend: transactionController (806 lines) split into transaction/ subfolder with crud, stats and helpers files. walletController (359 lines) split into wallet/ subfolder with query and mutation handlers. Routers updated. Frontend: extracted TransactionFormFields shared between Add and Change popups, TransactionRow and skeleton from WatchTransactionsPopup, moved extractApiErrorMessage to utils/functions.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split oversized backend controllers and frontend components into smaller, focused files.
Backend
transactionController.ts(806 lines) split intocontrollers/transaction/:transactionHelpers.ts- shared types and formatTransactiontransactionCrudHandlers.ts- CRUD handlerstransactionStatsHandlers.ts- portfolio, coin stats, chart datawalletController.ts(359 lines) split intocontrollers/wallet/:walletQueryHandlers.ts- getWallets, getWalletwalletMutationHandlers.ts- createWallet, updateWallet, deleteWalletRouters updated to import from new subfolder files.
Frontend
TransactionFormFields.tsx- shared form fields extracted from AddTransactionPopup and ChangeTransactionPopupTransactionRow.tsx- single row and skeleton extracted from WatchTransactionsPopupextractApiErrorMessagemoved toutils/functions.ts, duplication removedFiles left untouched:
transaction.api.ts,auth.api.ts(single createApi slices),Background.tsx,AllCrypto.tsx- all logically cohesive despite size.Testing
All 22 backend integration tests pass. TypeScript check clean on both frontend and backend.