Manual PE approval flow creates DNS record after approval

[timja]

Overview/Summary

If you don't have write access on both sides of a private endpoint connection an approval request is sent to the resource owner. The policy previously didn't add DNS records for this flow.

Now it adds the records after the approval takes place

This PR fixes/adds/changes/removes

Fixes Azure/Azure-Landing-Zones#4136

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

DNS record that was added after approval:

Testing URLs

The below URLs can be updated where the placeholders are, look for manual-private-endpoint-approval & manual-private-endpoint-approval, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Azure US Gov (Fairfax)

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Ensured contribution guidance is followed.
• Updated relevant and associated documentation.
• Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

[jtracey93]

Thanks @timja can you please install the latest version of Bicep and then run this command bicep build ./src/templates/policies.bicep --outfile ./eslzArm/managementGroupTemplates/policyDefinitions/policies.json to ensure the updates youve made are pulled into the policies.json is updated

[jtracey93]

really sorry @timja - could you pull in the latest changes from main and then re-run the bicep build command as we have had a few PRs queued up causing some merge conflicts - apologies