This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Pass in query params to the websockets requests#182
Open
larsderidder wants to merge 1 commit intoAxisCommunications:mainfrom
Open
Pass in query params to the websockets requests#182larsderidder wants to merge 1 commit intoAxisCommunications:mainfrom
larsderidder wants to merge 1 commit intoAxisCommunications:mainfrom
Conversation
Member
|
Thanks for your interest! Yes, I think it would be best if these are optional, separate search params. |
steabert
reviewed
May 13, 2022
| const wsUri = ( | ||
| protocol: Protocol.WS | Protocol.WSS, | ||
| host: string, | ||
| searchParams: string, |
Member
There was a problem hiding this comment.
Suggested change
| searchParams: string, | |
| searchParams?: string, |
steabert
reviewed
May 13, 2022
Comment on lines
+248
to
+250
| searchParams(FORMAT_API[format], { | ||
| ...parameters, | ||
| }), |
Member
There was a problem hiding this comment.
This would also need to be optional somehow, as I guess this is specific for your setup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to pass in query parameters to the websockets request. These are then intercepted by an nginx reverse proxy. Perhaps a bit of an edge case, but it does add flexibility (and in my case allows for authenticating the stream).
For this I use the same search params as used in the RTSP URI. If this does any harm I think I could introduce a separate params fields.