Rename PipsPager button theme APIs#20954
Open
jsuarezruiz wants to merge 4 commits intoAvaloniaUI:masterfrom
Open
Rename PipsPager button theme APIs#20954jsuarezruiz wants to merge 4 commits intoAvaloniaUI:masterfrom
jsuarezruiz wants to merge 4 commits intoAvaloniaUI:masterfrom
Conversation
MrJul
reviewed
Mar 20, 2026
Member
MrJul
left a comment
There was a problem hiding this comment.
The DrawerPageTests needs updating. Otherwise LGTM!
…rezruiz/Avalonia into fix-pipspager-inconsistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR apply changes around API inconsistencies.
It:
PipsPager.PreviousButtonStyle/NextButtonStyletoPreviousButtonTheme/NextButtonThemeNavigationPage.IsBackButtonEffectivelyVisiblefrombool?toboolThe
PipsPagerrename is intentional because these properties are typed asControlThemeand are applied throughButton.Theme, so*Themeis the correct Avalonia terminology. The previous*Stylenames were inspired from WinUI naming, but in Avalonia they are misleading and suggest aStylebased customization point that does not actually exist.What is the current behavior?
Currently:
NavigationPage.IsBackButtonEffectivelyVisibleis exposed asbool?even though consumers treat it as a boolean statePipsPagerexposesControlThemetyped properties namedPreviousButtonStyle/NextButtonStyle, which is inconsistent with Avalonia theme terminologyNavigationPagedoes not react whenHasBackButtonchanges on the currently displayed pageWhat is the updated/expected behavior with this PR?
With this PR:
NavigationPage.IsBackButtonEffectivelyVisibleis a non-nullableboolPipsPagerusesPreviousButtonTheme/NextButtonThemePipsPagerproperties correctlyHow was the solution implemented (if it's not obvious)?
Implementation details:
IsBackButtonEffectivelyVisiblewas updated to use abooldirect property and backing fieldPipsPagerrenamed the public styled properties and both shipped themes were updated to template-bind PreviousButtonTheme/NextButtonTheme`Checklist
Breaking changes
This PR intentionally changes public API names before release:
PipsPager.PreviousButtonStyle->PipsPager.PreviousButtonThemePipsPager.NextButtonStyle->PipsPager.NextButtonThemeNavigationPage.IsBackButtonEffectivelyVisiblechanges frombool?toboolObsoletions / Deprecations
None.
Fixed issues
None.