Implement XDND: drag-and-drop support for Linux#20926
Draft
MrJul wants to merge 18 commits intoAvaloniaUI:masterfrom
Draft
Implement XDND: drag-and-drop support for Linux#20926MrJul wants to merge 18 commits intoAvaloniaUI:masterfrom
MrJul wants to merge 18 commits intoAvaloniaUI:masterfrom
Conversation
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR implements XDND for Avalonia's X11 platform, allowing windows to act as drag sources and drop targets.
In short, drag-and-drop now works across processes on Linux.
How was the solution implemented (if it's not obvious)?
This PR supersedes #19232, which had several identified core problems: threading issues and re-implementations of existing algorithms already provided by the clipboard.
Instead, this PR tries to share most of its code with the clipboard implementation, since the underlying concepts are similar.
Key points:
Selection[...]classes, withClipboardandDragDropinheritors.SynchronousXEventWaitertype waits for specific matching events synchronously while reading from a selection, and puts back unused events onto the standard queue.Draft
This PR works. However, there are two points remaining:
XdndFinishedmessage in time, effectively hanging the drop operation.Fixed issues