fix: guard against undefined value in CSS variable resolution#604
Conversation
When a CSS property has an undefined value, replaceVariables() crashes with 'Cannot read properties of undefined (reading indexOf)' because uniqueString() calls string.indexOf() on the undefined value. Add a type check at the start of replaceVariables to return early for non-string values. Fixes #582
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
TypeError: Cannot read properties of undefined (reading 'indexOf')whenresolveCSSVariablesis enabled and a CSS property has an undefined value.Root cause
replaceVariables()inlib/variables.jspassesvaluetouniqueString()which callsstring.indexOf(). Whenvalueis undefined (e.g., from malformed CSS), this crashes.Fix
Add a type check at the start of
replaceVariables()to return early for non-string values.Tests
All 103 existing tests pass.
Fixes #582