EMSUSDC-405 Integrate Path Viewer into Asset Resolver dialog#4579
Open
AramAzhari-adsk wants to merge 9 commits intodevfrom
Open
EMSUSDC-405 Integrate Path Viewer into Asset Resolver dialog#4579AramAzhari-adsk wants to merge 9 commits intodevfrom
AramAzhari-adsk wants to merge 9 commits intodevfrom
Conversation
- Renamed Preferences Application Host to AssetResolverAppliactionHost - Updated AssetResolverDialogCmd command to accept tab selection
AramAzhari-adsk
commented
Apr 17, 2026
| { | ||
| switch (name) { |
Collaborator
Author
There was a problem hiding this comment.
Tested this, all Global Settings icons appear correctly.
There was a problem hiding this comment.
Pull request overview
This PR updates the MayaUSD Asset Resolver UI integration to use the newer Path Viewer–based dialog and to make the Asset Resolver dialog non-modal, aligning with EMSUSDC-405 and EMSUSDC-254.
Changes:
- Replace the old modal
USDAssetResolverDialogimplementation withAdsk::AssetResolverPathDialogand add tab-selection support (pathsvsglobalSettings). - Update preferences initialization and host integration to use the new
AssetResolverWidgetsAPIs/library. - Update CMake and find-module logic to link against the new Asset Resolver widgets/dialog library.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/adsk/scripts/mayaUsd_preferenceTab.mel | Updates the Preferences button handler to open the Asset Resolver dialog directly on the settings tab. |
| lib/usd/ui/assetResolver/AssetResolverDialogCmd.cpp | Reworks the assetResolverDialog command to show a singleton non-modal AssetResolverPathDialog, adds -tab flag, and wires settings persistence. |
| lib/usd/ui/assetResolver/PreferencesManagement.cpp | Switches to the new AssetResolverWidgets settings headers and the renamed application host. |
| lib/usd/ui/assetResolver/AssetResolverApplicationHost.h / .cpp | Renames/rebases the application host to the AssetResolverWidgets host API. |
| lib/usd/ui/assetResolver/AssetResolverUtils.cpp | Updates include to the new widgets settings management header. |
| lib/usd/ui/assetResolver/CMakeLists.txt | Replaces old sources/headers (removes USDAssetResolverDialog*, renames host files) to match the new dialog approach. |
| lib/usd/ui/CMakeLists.txt | Updates link dependency from the old preferences library to the new dialog/widgets library. |
| cmake/modules/FindAdskUsdAssetResolver.cmake | Renames the discovered library variable and updates lookup to AssetResolverWidgets. |
| lib/usd/ui/assetResolver/USDAssetResolverDialog.h / .cpp | Removed (dialog implementation superseded by AssetResolverPathDialog). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AssetResolverDialogCmd::finalize() calls close() on the dialog and WA_DeleteOnClose triggers deletion The QPointer automatically becomes null and no dangling callbacks can call into unloaded code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EMSUSDC-405 Integrate Path Viewer into Asset Resolver dialog
EMSUSDC-254 Make Asset Resolver dialog non-modal