Skip to content

Remove ci.yml (pull_request_target with unprotected environment)#62

Merged
visch merged 1 commit into
mainfrom
security/remove-pull-request-target-ci
May 22, 2026
Merged

Remove ci.yml (pull_request_target with unprotected environment)#62
visch merged 1 commit into
mainfrom
security/remove-pull-request-target-ci

Conversation

@visch

@visch visch commented May 22, 2026

Copy link
Copy Markdown
Contributor

Security fix: remove pull_request_target workflow

ci.yml triggers on pull_request_target and uses the authorize/environment gate to protect a test job holding 6 Google Ads OAuth secrets. But the external environment has no required_reviewers (unlike the correctly-configured tap-bls), so the gate is a no-op.

Not currently exploitable (no PR-head checkout → runs trusted base code), but it's a footgun: adding ref: head.sha to 'actually test PRs' would turn it into full secret exfiltration.

Per maintainer decision, removing the workflow entirely to eliminate the attack surface. Note: this drops all CI on the repo (build matrix + secret test); a push-only CI can be added back later if desired.

🤖 Generated with Claude Code


Note

Medium Risk
Removes the repository’s GitHub Actions CI pipeline, which reduces security exposure but also eliminates automated build/test coverage on pushes and PRs.

Overview
Removes the GitHub Actions workflow ci.yml, eliminating the build matrix and the secret-backed test job that previously ran under pull_request_target with an environment gate.

As a result, this PR drops all automated CI from the repository (no build or tox test runs via GitHub Actions).

Reviewed by Cursor Bugbot for commit 9d6a3e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@visch visch deployed to internal May 22, 2026 16:52 — with GitHub Actions Active
@visch visch merged commit d4f14f8 into main May 22, 2026
2 of 12 checks passed
@visch visch deleted the security/remove-pull-request-target-ci branch May 22, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant