Use absolute URLs for submodules improve fork cloneability#86
Open
cyberman wants to merge 1 commit intoArtifexSoftware:masterfrom
Open
Use absolute URLs for submodules improve fork cloneability#86cyberman wants to merge 1 commit intoArtifexSoftware:masterfrom
cyberman wants to merge 1 commit intoArtifexSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces namespace-relative submodule URLs with explicit upstream URLs.
Rationale:
The current relative URLs work inside the upstream repository namespace, but they can break
git clone --recurse-submodulesfor ordinary public forks unless all sibling submodule repositories also exist under the forker account or organization.This does not change MuPDF functionality.
It only improves clone behavior and reduces friction for fork-based workflows, including GitHub Desktop and recursive clone usage outside the upstream namespace.