spoolman: add support for aditional headers #870
Open
LobodPl wants to merge 4 commits intoArksine:masterfrom
Open
spoolman: add support for aditional headers #870LobodPl wants to merge 4 commits intoArksine:masterfrom
LobodPl wants to merge 4 commits intoArksine:masterfrom
Conversation
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Owner
|
Thanks. I'm a bit weary of adding this functionality directly to Moonraker. It seems like it would be possible to proxy requests to Spoolman and add any additional necessary headers there, which would be the preferable way of handling unique setups that don't apply to the majority of users. |
Author
Hello, good point of view. For me my change is as rare as use of the spoolman itself, but right now I'm also sceptic if it should be a part of moonraker itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional_headers parameter, to define extra headers passed with all spoolman requests.
Use case:
Spoolman has no auth and api is all public.
You use your printers in different locations, so you put Spoolman behind ZeroTrust (CloudFlare for example) to use only 1 instance.
You will need to pass extradata along with all spoolman requests to get through ZeroTrust Gateway.