Skip to content

spoolman: add support for aditional headers #870

Open
LobodPl wants to merge 4 commits intoArksine:masterfrom
LobodPl:master
Open

spoolman: add support for aditional headers #870
LobodPl wants to merge 4 commits intoArksine:masterfrom
LobodPl:master

Conversation

@LobodPl
Copy link
Copy Markdown

@LobodPl LobodPl commented Jun 17, 2024

Adds additional_headers parameter, to define extra headers passed with all spoolman requests.

Use case:
Spoolman has no auth and api is all public.
You use your printers in different locations, so you put Spoolman behind ZeroTrust (CloudFlare for example) to use only 1 instance.
You will need to pass extradata along with all spoolman requests to get through ZeroTrust Gateway.

LobodPl added 4 commits June 17, 2024 18:28
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
@Arksine
Copy link
Copy Markdown
Owner

Arksine commented Jun 23, 2024

Thanks. I'm a bit weary of adding this functionality directly to Moonraker. It seems like it would be possible to proxy requests to Spoolman and add any additional necessary headers there, which would be the preferable way of handling unique setups that don't apply to the majority of users.

@LobodPl
Copy link
Copy Markdown
Author

LobodPl commented Jun 23, 2024

Thanks. I'm a bit weary of adding this functionality directly to Moonraker. It seems like it would be possible to proxy requests to Spoolman and add any additional necessary headers there, which would be the preferable way of handling unique setups that don't apply to the majority of users.

Hello, good point of view. For me my change is as rare as use of the spoolman itself, but right now I'm also sceptic if it should be a part of moonraker itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants