Proposal: check for and use system-wide Amber#8
Open
Thesola10 wants to merge 5 commits intoArjixWasTaken:mainfrom
Open
Proposal: check for and use system-wide Amber#8Thesola10 wants to merge 5 commits intoArjixWasTaken:mainfrom
Thesola10 wants to merge 5 commits intoArjixWasTaken:mainfrom
Conversation
Merged
Owner
|
Good idea having it as fallback |
Owner
|
@Thesola10 can you confirm if my changes have not broken your intended behavior? |
Owner
|
I believe this PR should modify the nix stuff, these two lines should be redundant. https://github.com/ArjixWasTaken/amethyst/blob/main/default.nix#L9-L10 |
Contributor
Author
|
that's the idea, but right now these lines address the bootstrap version of Amethyst, we'd need to backport this PR to it |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets Amethyst run
amber --versionon whichever version of Amber is inPATH, and if the version matches, uses it to build even if the manifest specifies an explicit version.The check is a substring because, due to Nix sandboxing, the Amber built from the upstream Nix flake will report its version in the form
amber 0.5.1-alpha-nix-eb391e2even if built from a release tag.