Open
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix metadata serialization for non-dict LLM settings in pipecat instrumentor
Problem
When using pipecat with Google Gemini (or other providers with Pydantic model settings), the
metadataspan attribute was being set to a Python repr string like:This caused export failures with
StatusCode.UNKNOWNbecause the Arize backend requiresmetadatato be valid JSON.Fix
In
_attributes.py, theLLMServiceAttributeExtractor.extract_from_servicemethod now converts non-dict settings objects to dicts before JSON serialization, usingmodel_dump()(Pydantic v2),dict()(Pydantic v1), or__dict__as fallbacks.Testing
All 66 existing tests pass.