Use argcomplete stubs for mypy type checking#153
Closed
amilcarlucas wants to merge 1 commit intomasterfrom
Closed
Conversation
amilcarlucas
force-pushed
the
argcomplete_mypy_stubs
branch
from
488034f to
99099e0
Compare
Contributor
Test Results 2 files 2 suites 1m 34s ⏱️ Results for commit 363e747. ♻️ This comment has been updated with latest results. |
amilcarlucas
force-pushed
the
argcomplete_mypy_stubs
branch
from
99099e0 to
363e747
Compare
Contributor
There was a problem hiding this comment.
PR Overview
This PR integrates argcomplete stubs into the project to support improved mypy type checking and updates license annotations accordingly.
- Adds a mypy_path configuration to include argcomplete stubs in pyproject.toml.
- Updates REUSE.toml to annotate the stub files for proper license compliance.
Reviewed Changes
| File | Description |
|---|---|
| pyproject.toml | Adds a mypy_path setting for argcomplete stubs |
| REUSE.toml | Adds annotations for the argcomplete stub files |
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pyproject.toml:242
- Consider placing 'mypy_path' under a dedicated [tool.mypy] section to ensure it is properly recognized by mypy. If leaving it at the top level is intentional due to a custom configuration, please add a clarifying comment.
mypy_path = "out/argcomplete"
amilcarlucas
force-pushed
the
argcomplete_mypy_stubs
branch
from
363e747 to
d779225
Compare
Collaborator
Author
|
It looks like this is not really needed, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
REUSE.tomlandpyproject.tomlfiles to add new paths and configurations.Changes to
REUSE.toml:out/argcomplete/**/*path with the appropriate SPDX license information.Changes to
pyproject.toml:mypy_pathconfiguration for theargcompletepackage to include stub files generated withstubgen.