Skip to content

ci(fork repos): Do not create banches and commits in forks#1395

Merged
amilcarlucas merged 3 commits intomasterfrom
do_not_create_branches_on_forks
Mar 20, 2026
Merged

ci(fork repos): Do not create banches and commits in forks#1395
amilcarlucas merged 3 commits intomasterfrom
do_not_create_branches_on_forks

Conversation

@amilcarlucas
Copy link
Collaborator

It only clutters the fork repos with unused branches

Copilot AI review requested due to automatic review settings March 20, 2026 10:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents several automation workflows from running in forked repositories to avoid creating unnecessary branches/commits in forks.

Changes:

  • Add a job-level guard (if: github.repository == 'ArduPilot/MethodicConfigurator') to skip execution in forks.
  • Apply the same fork-skip behavior across multiple update/translation workflows.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/update_vehicle_templates.yml Skip template-update job unless running in the upstream repo
.github/workflows/update_vehicle_components_translation.yaml Skip components translation update job unless running in the upstream repo
.github/workflows/update_motor_diagrams.yml Skip motor diagrams update job unless running in the upstream repo
.github/workflows/update_magfit_pdef_xml.yml Skip magfit pdef xml update job unless running in the upstream repo
.github/workflows/update_flightcontroller_ids.yml Skip flight controller IDs update job unless running in the upstream repo
.github/workflows/update_copyright_year.yml Skip copyright update job unless running in the upstream repo
.github/workflows/update_configuration_steps_translation.yaml Skip configuration steps translation job unless running in the upstream repo
.github/workflows/update_codebase_chart.yml Skip codebase chart update job unless running in the upstream repo
.github/workflows/ai-translation.yml Skip AI translation extraction job unless running in the upstream repo

@amilcarlucas amilcarlucas force-pushed the do_not_create_branches_on_forks branch from 838cd39 to 5898352 Compare March 20, 2026 11:02
@amilcarlucas amilcarlucas requested a review from Copilot March 20, 2026 11:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

@amilcarlucas amilcarlucas force-pushed the do_not_create_branches_on_forks branch from 5898352 to 9ce423a Compare March 20, 2026 12:30
@amilcarlucas amilcarlucas requested a review from Copilot March 20, 2026 12:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11760 10937 93% 89% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: bca4318 by action🐍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23339984049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.095%

Totals Coverage Status
Change from base Build 23336089139: 0.0%
Covered Lines: 10948
Relevant Lines: 11760

💛 - Coveralls

@amilcarlucas
Copy link
Collaborator Author

@OmkarSarkar204 the test tests/unit_frontend_tkinter_battery_monitor.py::TestUploadButtonErrorHandling::test_upload_button_click_when_ui_services_unavailable is blocking on macOS on this branch. Can you please take a look at it?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Test Results

    3 files   -     1      3 suites   - 1   35m 52s ⏱️ - 4m 58s
3 309 tests ±    0  3 305 ✅  -     2   4 💤 +2  0 ❌ ±0 
9 797 runs   - 3 231  9 782 ✅  - 3 227  15 💤  - 4  0 ❌ ±0 

Results for commit bca4318. ± Comparison against base commit 5ff9fc1.

This pull request skips 2 tests.
tests.gui_frontend_tkinter_show.TestTooltipUserExperienceIntegration ‑ test_gui_functionality_on_macos
tests.gui_frontend_tkinter_show.TestTooltipUserExperienceIntegration ‑ test_tooltip_positioning_with_retina_display

♻️ This comment has been updated with latest results.

@amilcarlucas amilcarlucas merged commit e83c199 into master Mar 20, 2026
34 of 38 checks passed
@amilcarlucas amilcarlucas deleted the do_not_create_branches_on_forks branch March 20, 2026 20:34
@OmkarSarkar204
Copy link
Contributor

@OmkarSarkar204 the test tests/unit_frontend_tkinter_battery_monitor.py::TestUploadButtonErrorHandling::test_upload_button_click_when_ui_services_unavailable is blocking on macOS on this branch. Can you please take a look at it?

sure and sorry for being late,
test passes perfectly locally but gives the "139" error, could be tk_root the same error was seen during the mac fix.

Isnt there a complete fix for this?

@amilcarlucas
Copy link
Collaborator Author

I fixed it by changing a focus_force to a foucus_set call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants