ci(fork repos): Do not create banches and commits in forks#1395
ci(fork repos): Do not create banches and commits in forks#1395amilcarlucas merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents several automation workflows from running in forked repositories to avoid creating unnecessary branches/commits in forks.
Changes:
- Add a job-level guard (
if: github.repository == 'ArduPilot/MethodicConfigurator') to skip execution in forks. - Apply the same fork-skip behavior across multiple update/translation workflows.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update_vehicle_templates.yml | Skip template-update job unless running in the upstream repo |
| .github/workflows/update_vehicle_components_translation.yaml | Skip components translation update job unless running in the upstream repo |
| .github/workflows/update_motor_diagrams.yml | Skip motor diagrams update job unless running in the upstream repo |
| .github/workflows/update_magfit_pdef_xml.yml | Skip magfit pdef xml update job unless running in the upstream repo |
| .github/workflows/update_flightcontroller_ids.yml | Skip flight controller IDs update job unless running in the upstream repo |
| .github/workflows/update_copyright_year.yml | Skip copyright update job unless running in the upstream repo |
| .github/workflows/update_configuration_steps_translation.yaml | Skip configuration steps translation job unless running in the upstream repo |
| .github/workflows/update_codebase_chart.yml | Skip codebase chart update job unless running in the upstream repo |
| .github/workflows/ai-translation.yml | Skip AI translation extraction job unless running in the upstream repo |
838cd39 to
5898352
Compare
It only clutters the fork repos with unused branches
5898352 to
9ce423a
Compare
9ce423a to
bca4318
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Pull Request Test Coverage Report for Build 23339984049Details
💛 - Coveralls |
|
@OmkarSarkar204 the test tests/unit_frontend_tkinter_battery_monitor.py::TestUploadButtonErrorHandling::test_upload_button_click_when_ui_services_unavailable is blocking on macOS on this branch. Can you please take a look at it? |
Test Results 3 files - 1 3 suites - 1 35m 52s ⏱️ - 4m 58s Results for commit bca4318. ± Comparison against base commit 5ff9fc1. This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
sure and sorry for being late, Isnt there a complete fix for this? |
|
I fixed it by changing a focus_force to a foucus_set call. |
It only clutters the fork repos with unused branches